[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] master 890cf81 27/31: Merge pull request #434 from lelit/issue420
From: |
Dmitry Gutov |
Subject: |
[elpa] master 890cf81 27/31: Merge pull request #434 from lelit/issue420 |
Date: |
Fri, 21 Jul 2017 09:04:59 -0400 (EDT) |
branch: master
commit 890cf817bbc206b2764c3f96f23613318bd47934
Merge: b176925 a604872
Author: Dmitry Gutov <address@hidden>
Commit: GitHub <address@hidden>
Merge pull request #434 from lelit/issue420
Attempt to fix issue 420
---
js2-mode.el | 4 ++++
tests/parser.el | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/js2-mode.el b/js2-mode.el
index 9b7f7fd..dca862a 100644
--- a/js2-mode.el
+++ b/js2-mode.el
@@ -7205,6 +7205,10 @@ When STRICT, signal an error if NODE is not one of the
expected types."
(setq targets (append
(js2--collect-target-symbols subexpr strict)
targets))))))
+ ((js2-assign-node-p node)
+ (setq targets (append (js2--collect-target-symbols
+ (js2-assign-node-left node) strict)
+ targets)))
(strict
(js2-report-error "msg.no.parm" nil (js2-node-abs-pos node)
(js2-node-len node))
diff --git a/tests/parser.el b/tests/parser.el
index 181e741..c81ac0b 100644
--- a/tests/parser.el
+++ b/tests/parser.el
@@ -1255,6 +1255,10 @@ the test."
"function foo() { let {a, b, c = 3} = {a: 1, b: 2}; }"
'("address@hidden:U" "address@hidden:U" "address@hidden:U"
"address@hidden:U"))
+(js2-deftest-classify-variables destructure-object-missing
+ "function foo() { let {foo: missing = 10} = {}; }"
+ '("address@hidden:U" "address@hidden:U"))
+
;; Side effects
(js2-deftest no-side-effects-at-top-level
- [elpa] master 659f683 14/31: Merge pull request #421 from raxod502/feat/C-M-j, (continued)
- [elpa] master 659f683 14/31: Merge pull request #421 from raxod502/feat/C-M-j, Dmitry Gutov, 2017/07/21
- [elpa] master 8a5f492 20/31: Merge pull request #425 from shicks/jsdoc, Dmitry Gutov, 2017/07/21
- [elpa] master d3b31ba 10/31: js2-node-qname-component: Nandle computed properties, Dmitry Gutov, 2017/07/21
- [elpa] master 4a87822 13/31: Map C-M-j to js2-line-break, Dmitry Gutov, 2017/07/21
- [elpa] master ca7df5b 16/31: Merge branch 'master' of github.com:mooz/js2-mode, Dmitry Gutov, 2017/07/21
- [elpa] master b3f74f0 19/31: Fix jsdoc highlighting for tags w/ optional braces, Dmitry Gutov, 2017/07/21
- [elpa] master 9ce2542 07/31: Add support for ES7 class public fields, Dmitry Gutov, 2017/07/21
- [elpa] master 7349309 21/31: Add tests for `/*jslint*/` declarations, Dmitry Gutov, 2017/07/21
- [elpa] master b176925 24/31: Update NEWS.md, Dmitry Gutov, 2017/07/21
- [elpa] master 92a8857 23/31: Support async arrow function without parentheses, Dmitry Gutov, 2017/07/21
- [elpa] master 890cf81 27/31: Merge pull request #434 from lelit/issue420,
Dmitry Gutov <=
- [elpa] master 558f53f 22/31: Merge pull request #358 from JulianKniephoff/master, Dmitry Gutov, 2017/07/21
- [elpa] master cb57d9b 30/31: Bump the version, Dmitry Gutov, 2017/07/21
- [elpa] master a604872 26/31: Recognize initialized variable in destructuring object assignment, Dmitry Gutov, 2017/07/21
- [elpa] master f1badee 18/31: Replace (equal nil ...) with (null ...), Dmitry Gutov, 2017/07/21
- [elpa] master 2c459c6 29/31: Merge pull request #436 from felipeochoa/issue429, Dmitry Gutov, 2017/07/21
- [elpa] master 3df50ab 17/31: Add option js2-getprop-has-side-effects (#424), Dmitry Gutov, 2017/07/21
- [elpa] master 867919e 28/31: Always consider `await` to have side-effects, Dmitry Gutov, 2017/07/21
- [elpa] master 97d27d6 15/31: Put the visitor and printer properties on unprefixed symbols as well, Dmitry Gutov, 2017/07/21
- [elpa] master 231ac7f 31/31: Merge commit 'cb57d9b67390ae3ff70ab64169bbc4f1264244bc' from js2-mode, Dmitry Gutov, 2017/07/21