[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/ebdb aae57ff 139/350: Ensure that extra name field inst
From: |
Eric Abrahamsen |
Subject: |
[elpa] externals/ebdb aae57ff 139/350: Ensure that extra name field instances go in 'aka slot |
Date: |
Mon, 14 Aug 2017 11:46:23 -0400 (EDT) |
branch: externals/ebdb
commit aae57ffba49cef6497a8c30e905cc2900cc06b7b
Author: Eric Abrahamsen <address@hidden>
Commit: Eric Abrahamsen <address@hidden>
Ensure that extra name field instances go in 'aka slot
* ebdb.el (ebdb-field-name): This should subclass ebdb-field, not
ebdb-field-user, or else instances will go in the 'fields slot.
(ebdb-record-field-slot-query): Must explicitly list the types of
name class, and the fact they both go in the 'aka slot.
There's actually no reason to have a separate 'aka slot --
initialization and caching does everything that needs doing with name
instances.
---
ebdb.el | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/ebdb.el b/ebdb.el
index b6b01f0..109dc54 100644
--- a/ebdb.el
+++ b/ebdb.el
@@ -747,7 +747,7 @@ process."
;;; The name fields. One abstract base class, and two instantiable
;;; subclasses.
-(defclass ebdb-field-name (ebdb-field-user)
+(defclass ebdb-field-name (ebdb-field)
nil
:abstract t
:documentation "Abstract base class for creating record
@@ -2157,13 +2157,9 @@ priority."
;; TODO: There's no reason why the aka slot can't belong to
;; `ebdb-record-entity'. In fact, what we ought to do is put both the
;; 'name and the 'aka slots on `ebdb-record-entity', and have both
-;; slot types set to `ebdb-field-name'. Then provide a fairly simple
-;; mechanism for letting the user choose whether a name/aka should be
-;; simple or complex. Or, when creating or parsing name fields, we
-;; could always start out with the `ebdb-parse' and `ebdb-read'
-;; methods of `ebdb-field-name', which could then dispatch to the
-;; simple/complex methods depending on the initial string values. Or
-;; something like that.
+;; slot types set to `ebdb-field-name'. Or why not just get rid of
+;; the 'aka slot altogether, and put extra name instances in 'fields?
+;; What's the point of keeping them in an extra slot?
(defclass ebdb-record-person (ebdb-record-entity)
((name
@@ -2258,6 +2254,7 @@ priority."
query
(append
'((aka . ebdb-field-name-complex)
+ (aka . ebdb-field-name-simple)
(relations . ebdb-field-relation)
(organizations . ebdb-field-role))
alist)))
- [elpa] externals/ebdb f1448f4 174/350: Remove this empty file, (continued)
- [elpa] externals/ebdb f1448f4 174/350: Remove this empty file, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 6479c87 173/350: Remove unused code, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb db930f6 163/350: Compiler-inspired fixes, and removal of old-code references, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 281c61e 154/350: Don't ((lambda ()), Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 4cce4c8 096/350: Simplify role field adoption process, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 0910ddd 105/350: Change default of ebdb-default-user-field, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb b495e29 083/350: Omnibus changes to display and redisplay, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 29bf304 101/350: Rework MUA window popups, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 81e23c3 134/350: Simplify record mail citing, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb b661aac 124/350: First generalized version of snarfing, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb aae57ff 139/350: Ensure that extra name field instances go in 'aka slot,
Eric Abrahamsen <=
- [elpa] externals/ebdb 057c4c0 144/350: Have ebdb-snarf accept optional records argument, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 8d81a19 132/350: Add EBDB record citation, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 7662133 140/350: Simplify ebdb-dwim-mail, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 0cfe1ec 164/350: Provide keybinding for ebdb-format-all-records, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb bf51b58 161/350: Fix ebdb-delete-redundant-mails, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 279eb56 169/350: Tweaks and additions to manual, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb eea0abf 165/350: VCard export is good enough, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 64b5e43 170/350: Fix autoloads in ebdb.el, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb a968dd3 143/350: First actually-working version of snarfing, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb a8e0221 179/350: Missing local variable binding, Eric Abrahamsen, 2017/08/14