[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/elpa 05c67ee 112/139: Adjust flymake integration

From: João Távora
Subject: [elpa] externals/elpa 05c67ee 112/139: Adjust flymake integration
Date: Mon, 14 May 2018 09:53:46 -0400 (EDT)

branch: externals/elpa
commit 05c67eece9a94cf9f8ee58b18fb4a1318b2425b3
Author: João Távora <address@hidden>
Commit: João Távora <address@hidden>

    Adjust flymake integration
    When opening a new file (signalling textDocument/didOpen) it makes
    sense to call the flymake callback (if it exists) with no diagnostics,
    just to get rid of that "Wait", since we don't know if later in this
    callback cycle the server will ever report new diagnostics.
    * eglot.el (eglot--managed-mode): Don't call flymake-mode or eldoc-mode
    (eglot--managed-mode-hook): Add them here.
    (eglot--maybe-activate-editing-mode): Call flymake callback.
    (eglot--server-textDocument/publishDiagnostics): Set unreported
    diagnostics to nil if invoking callback.
 eglot.el | 29 ++++++++++++++---------------
 1 file changed, 14 insertions(+), 15 deletions(-)

diff --git a/eglot.el b/eglot.el
index 21ec247..f865c22 100644
--- a/eglot.el
+++ b/eglot.el
@@ -798,9 +798,7 @@ DEFERRED is passed to `eglot--request', which see."
     (add-hook 'completion-at-point-functions #'eglot-completion-at-point nil t)
     (add-function :before-until (local 'eldoc-documentation-function)
-    (add-function :around (local imenu-create-index-function) #'eglot-imenu)
-    (flymake-mode 1)
-    (eldoc-mode 1))
+    (add-function :around (local imenu-create-index-function) #'eglot-imenu))
     (remove-hook 'flymake-diagnostic-functions 'eglot-flymake-backend t)
     (remove-hook 'after-change-functions 'eglot--after-change t)
@@ -818,6 +816,9 @@ DEFERRED is passed to `eglot--request', which see."
       (when (and (process-live-p proc) (y-or-n-p "[eglot] Kill server too? "))
         (eglot-shutdown proc t))))))
+(add-hook 'eglot--managed-mode-hook 'flymake-mode)
+(add-hook 'eglot--managed-mode-hook 'eldoc-mode)
 (defun eglot--buffer-managed-p (&optional proc)
   "Tell if current buffer is managed by PROC."
   (and buffer-file-name (let ((cur (eglot--current-process)))
@@ -832,7 +833,8 @@ that case, also signal textDocument/didOpen."
   (when (eglot--buffer-managed-p proc)
     (eglot--managed-mode 1)
-    (flymake-start)))
+    (flymake-start)
+    (funcall (or eglot--current-flymake-report-fn #'ignore) nil)))
 (add-hook 'find-file-hook 'eglot--maybe-activate-editing-mode)
@@ -999,11 +1001,11 @@ called interactively."
                               (t               :note))
                         (concat source ": " message)))))
          into diags
-         finally (if eglot--current-flymake-report-fn
-                     (funcall eglot--current-flymake-report-fn
-                              diags)
-                   (setq eglot--unreported-diagnostics
-                         diags)))))
+         finally (cond (eglot--current-flymake-report-fn
+                        (funcall eglot--current-flymake-report-fn diags)
+                        (setq eglot--unreported-diagnostics nil))
+                       (t
+                        (setq eglot--unreported-diagnostics diags))))))
       (eglot--message "OK so %s isn't visited" filename)))))
@@ -1174,15 +1176,12 @@ Records START, END and PRE-CHANGE-LENGTH locally."
 (defun eglot-flymake-backend (report-fn &rest _more)
   "An EGLOT Flymake backend.
 Calls REPORT-FN maybe if server publishes diagnostics in time."
-  ;; Maybe call immediately if anything unreported (this will clear
-  ;; any pending diags)
+  (setq eglot--current-flymake-report-fn report-fn)
+  ;; Report anything unreported
   (when eglot--unreported-diagnostics
     (funcall report-fn eglot--unreported-diagnostics)
     (setq eglot--unreported-diagnostics nil))
-  ;; Setup so maybe it's called later, too.
-  (setq eglot--current-flymake-report-fn report-fn)
-  ;; Take this opportunity to signal a didChange that might eventually
-  ;; make the server report new diagnostics.
+  ;; Signal a didChange that might eventually bring new diagnotics
 (defun eglot-xref-backend ()

reply via email to

[Prev in Thread] Current Thread [Next in Thread]