[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/frog-menu a33cc1b: * frog-menu.el: Address some compile

From: Stefan Monnier
Subject: [elpa] externals/frog-menu a33cc1b: * frog-menu.el: Address some compiler warnings
Date: Sun, 24 Mar 2019 09:42:21 -0400 (EDT)

branch: externals/frog-menu
commit a33cc1b0b120ef356c1ebc97b2ea7dca5ec7605b
Author: Stefan Monnier <address@hidden>
Commit: Stefan Monnier <address@hidden>

    * frog-menu.el: Address some compiler warnings
 frog-menu.el | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/frog-menu.el b/frog-menu.el
index ec1cf77..e472b47 100644
--- a/frog-menu.el
+++ b/frog-menu.el
@@ -365,7 +365,7 @@ horizontal direction which default to frame width.
 Returns the buffer containing the formatted grid."
-    (let* ((length (apply 'max
+    (let* ((length (apply #'max
                           (mapcar #'string-width strings)))
            (wwidth (or width (frame-width)))
            (columns (min cols (/ wwidth (+ frog-menu-min-col-padding length))))
@@ -492,13 +492,14 @@ buffer positions containing the candidates and default to
 (defun frog-menu--posframe-ace-handler (char)
   "Execute menu action for CHAR."
-  (cond ((memq char '(27 ?\C-g))
+  (cond ((memq char '(?\e ?\C-g))
          ;; exit silently
          (throw 'done 'exit))
         ((mouse-event-p char)
          (signal 'user-error (list "Mouse event not handled" char)))
          (require 'edmacro)
+         ;; FIXME: Why not `key-description'?
          (let* ((key (kbd (edmacro-format-keys (vector char))))
                 (cmd (lookup-key frog-menu--avy-action-map key)))
            (if (commandp cmd)
@@ -550,6 +551,8 @@ ACTIONS is the argument of `frog-menu-read'."
                      buffer window)))
     ;; init map which passes actions info to avy handler
     (frog-menu--init-avy-action-map actions)
+    ;; FIXME: These aren't found in my copy of avy!
+    (defvar avy-single-candidate-jump) (defvar avy-pre-action)
     (if candidates
         (let* ((avy-keys frog-menu-avy-keys)
                (avy-single-candidate-jump (null actions))

reply via email to

[Prev in Thread] Current Thread [Next in Thread]