emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] master 3c906cd 15/34: Always offer completions (workaround for co


From: Vitalie Spinu
Subject: [elpa] master 3c906cd 15/34: Always offer completions (workaround for company issue #476)
Date: Tue, 7 May 2019 16:05:27 -0400 (EDT)

branch: master
commit 3c906cd6e1115615a3c59fbdb4b4202ccd7541af
Author: Clément Pit--Claudel <address@hidden>
Commit: Clément Pit--Claudel <address@hidden>

    Always offer completions (workaround for company issue #476)
    
    The issue appears clearly when one wants to insert unicode symbols with
    short LaTeX names, such as ‘\Cap’, ‘\wp’, or ‘\wr’. The problem is that
    company-mode closes its popup if there is only one completion available,
    and it has been typed in full. In that case, even running
    ‘company-manual-begin’ has no effect; the only way to insert the
    corresponding unicode symbol is to remove the last character of the
    symbol, and to run ‘company-manual-begin’.
    
    This commit introduces the workaround discussed in
    https://github.com/company-mode/company-mode/issues/476: we add a space
    at the end of each symbol in ‘company-math-symbols-unicode’, to ensure
    that the user can always use ‘RET’ to insert Unicode symbols.
---
 company-math.el | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/company-math.el b/company-math.el
index 7f944ed..bf9d0e0 100644
--- a/company-math.el
+++ b/company-math.el
@@ -147,9 +147,13 @@ corresponding unicode symbol."
   (cl-case command
     (interactive (company-begin-backend 'company-math-symbols-unicode))
     (prefix (company-math--prefix company-math-allow-unicode-symbols-in-faces
-                                 
company-math-disallow-unicode-symbols-in-faces))
+                                  
company-math-disallow-unicode-symbols-in-faces))
     (annotation (concat " " (get-text-property 0 :symbol arg)))
-    (candidates (all-completions arg company-math--symbols))
+    ;; Space added to ensure that completions are never typed in full.
+    ;; See https://github.com/company-mode/company-mode/issues/476
+    (candidates (mapcar (lambda (candidate)
+                          (concat candidate " "))
+                        (all-completions arg company-math--symbols)))
     (post-completion (company-math--substitute-unicode
                      (get-text-property 0 :symbol arg)))))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]