[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/posframe 9a1a17b 08/40: Fix incorrect current-buffer bu
From: |
Feng Shu |
Subject: |
[elpa] externals/posframe 9a1a17b 08/40: Fix incorrect current-buffer bug in 'posframe-show' |
Date: |
Wed, 5 Feb 2020 04:27:17 -0500 (EST) |
branch: externals/posframe
commit 9a1a17b976500d00ebff588bd96b1607ea6c738a
Author: Štěpán Němec <address@hidden>
Commit: Štěpán Němec <address@hidden>
Fix incorrect current-buffer bug in 'posframe-show'
The function 'font-at' (called from 'posframe--get-font-height')
signals an error when the current buffer is different from the one
displayed in the selected window.
Make sure the correct buffer is current.
(This is not theoretical, I have actually bumped into the error
myself. It is not guaranteed that selected-window matches
current-buffer during 'posframe-show' invocation.)
---
posframe.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/posframe.el b/posframe.el
index 51bd925..6d99782 100644
--- a/posframe.el
+++ b/posframe.el
@@ -471,7 +471,8 @@ you can use `posframe-delete-all' to delete all posframes."
(parent-frame-width (frame-pixel-width parent-frame))
(parent-frame-height (frame-pixel-height parent-frame))
(font-width (default-font-width))
- (font-height (posframe--get-font-height position))
+ (font-height (with-current-buffer (window-buffer parent-window)
+ (posframe--get-font-height position)))
(mode-line-height (window-mode-line-height))
(minibuffer-height (window-pixel-height (minibuffer-window)))
(header-line-height (window-header-line-height parent-window))
- [elpa] externals/posframe updated (fc90a1a -> c250771), Feng Shu, 2020/02/05
- [elpa] externals/posframe d12d686 04/40: Improve 'posframe-show' documentation string, Feng Shu, 2020/02/05
- [elpa] externals/posframe 9900f93 06/40: Fix compiler and checkdoc warnings, Feng Shu, 2020/02/05
- [elpa] externals/posframe 3e02422 02/40: Fix compiler and checkdoc warnings, Feng Shu, 2020/02/05
- [elpa] externals/posframe 8242db6 03/40: Autoload the main entry point, Feng Shu, 2020/02/05
- [elpa] externals/posframe 3583a21 05/40: More documentation language improvements, Feng Shu, 2020/02/05
- [elpa] externals/posframe f44d3a5 09/40: Merge pull request #35 from stepnem/fix-warnings, Feng Shu, 2020/02/05
- [elpa] externals/posframe 427318d 01/40: Fix posframe-delete doesn't kill the posframe buffer #39, Feng Shu, 2020/02/05
- [elpa] externals/posframe 9a1a17b 08/40: Fix incorrect current-buffer bug in 'posframe-show',
Feng Shu <=
- [elpa] externals/posframe bf5bd24 14/40: Improve logic in 'posframe-funcall', Feng Shu, 2020/02/05
- [elpa] externals/posframe ab72f53 07/40: Autoload the main entry point, Feng Shu, 2020/02/05
- [elpa] externals/posframe 9520893 32/40: Merge pull request #49 from conao3/trivial-fix, Feng Shu, 2020/02/05
- [elpa] externals/posframe f02770e 22/40: Revert "'posframe-buffer-frame': New function to get a buffer's posframe", Feng Shu, 2020/02/05
- [elpa] externals/posframe 3c740c1 28/40: add convenience keyword, Feng Shu, 2020/02/05
- [elpa] externals/posframe 2c5f390 16/40: 'posframe-buffer-frame': New function to get a buffer's posframe, Feng Shu, 2020/02/05
- [elpa] externals/posframe fe57b4f 19/40: Don't modify global value of 'kill-buffer-hook', Feng Shu, 2020/02/05
- [elpa] externals/posframe e3fd09f 35/40: posframe-show: call redisplay to let border showed., Feng Shu, 2020/02/05
- [elpa] externals/posframe b77cd06 29/40: add space after period, Feng Shu, 2020/02/05
- [elpa] externals/posframe f413a4f 30/40: add center handler, Feng Shu, 2020/02/05