[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/modus-operandi-theme efb3ed4 022/112: Refine `font-lock
From: |
Stefan Monnier |
Subject: |
[elpa] externals/modus-operandi-theme efb3ed4 022/112: Refine `font-lock-warning-face' (see commit msg) |
Date: |
Mon, 30 Mar 2020 15:59:30 -0400 (EDT) |
branch: externals/modus-operandi-theme
commit efb3ed4dc17383cf9318030ab1fd9a45abe6287f
Author: Protesilaos Stavrou <address@hidden>
Commit: Protesilaos Stavrou <address@hidden>
Refine `font-lock-warning-face' (see commit msg)
While this is a small change, it actually is not as straightforward.
Normally `font-lock-*' faces are used _directly_ inside a buffer, but
not on the mode line (they can be used _indirectly_ by other faces that
inherit them). An exception to this norm is `font-lock-warning-face'.
The background values of a buffer and of the {in-,}active mode line vary
considerably. The latter uses the most pronounced background out of all
those that are meant to present accent colours (red, green, blue, etc.).
To conform with the overarching objective of this project with regard to
the WCAG AAA accessibility standard (contrast ratio >= 7:1), it is
necessary to choose colour combinations that take the background value
as a known constant.
Put differently, it is necessary to have accent values that are intended
for use in the mode line (or rather, to be combined with the mode line
backgrounds). The subset of colours whose name included the `-active'
suffix covers this particular need.
Couched in those terms, the use of `yellow-active' as a foreground
ensures that this face can appear in the mode line as well be cast on
all background values specified by my themes.
This commit addresses issue 20:
https://gitlab.com/protesilaos/modus-themes/-/issues/20
---
modus-operandi-theme.el | 2 +-
modus-vivendi-theme.el | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/modus-operandi-theme.el b/modus-operandi-theme.el
index 673b4ec..ede492e 100644
--- a/modus-operandi-theme.el
+++ b/modus-operandi-theme.el
@@ -1124,7 +1124,7 @@ between foreground and background is >= 7:1)."
`(font-lock-string-face ((,class (:foreground ,blue-alt))))
`(font-lock-type-face ((,class (:foreground ,magenta-alt))))
`(font-lock-variable-name-face ((,class (:foreground ,cyan))))
- `(font-lock-warning-face ((,class (:background ,bg-alt :foreground
,yellow-alt-other :weight bold))))
+ `(font-lock-warning-face ((,class (:foreground ,yellow-active :weight
bold))))
;;;; fountain-mode
`(fountain-character ((,class (:foreground ,magenta-alt-other))))
`(fountain-comment ((,class (:foreground ,fg-alt :slant
,modus-theme-slant))))
diff --git a/modus-vivendi-theme.el b/modus-vivendi-theme.el
index 113427f..ac5bc70 100644
--- a/modus-vivendi-theme.el
+++ b/modus-vivendi-theme.el
@@ -1124,7 +1124,7 @@ between foreground and background is >= 7:1)."
`(font-lock-string-face ((,class (:foreground ,blue-alt))))
`(font-lock-type-face ((,class (:foreground ,magenta-alt))))
`(font-lock-variable-name-face ((,class (:foreground ,cyan))))
- `(font-lock-warning-face ((,class (:background ,bg-alt :foreground
,yellow-alt-other :weight bold))))
+ `(font-lock-warning-face ((,class (:foreground ,yellow-active :weight
bold))))
;;;; fountain-mode
`(fountain-character ((,class (:foreground ,magenta-alt-other))))
`(fountain-comment ((,class (:foreground ,fg-alt :slant
,modus-theme-slant))))
- [elpa] externals/modus-operandi-theme de1fbdf 003/112: General refinements to built-in DIFF faces, (continued)
- [elpa] externals/modus-operandi-theme de1fbdf 003/112: General refinements to built-in DIFF faces, Stefan Monnier, 2020/03/30
- [elpa] externals/modus-operandi-theme 0413751 004/112: Add support for BUFFER-EXPOSE, Stefan Monnier, 2020/03/30
- [elpa] externals/modus-operandi-theme 4ad18ec 008/112: Add support for YAML-MODE (issue #17), Stefan Monnier, 2020/03/30
- [elpa] externals/modus-operandi-theme af0d20d 011/112: Add support for MULTIPLE-CURSORS (issue #17), Stefan Monnier, 2020/03/30
- [elpa] externals/modus-operandi-theme dd783f1 002/112: Modus operandi: minor documentation tweak, Stefan Monnier, 2020/03/30
- [elpa] externals/modus-operandi-theme 32cfacd 009/112: Add support for SYMBOL-OVERLAY (issue #17), Stefan Monnier, 2020/03/30
- [elpa] externals/modus-operandi-theme 6a605b5 010/112: Add support for HL-TODO (issue #17), Stefan Monnier, 2020/03/30
- [elpa] externals/modus-operandi-theme 4d97715 017/112: Internal: fix alphabetic order of some faces, Stefan Monnier, 2020/03/30
- [elpa] externals/modus-operandi-theme 83ab771 020/112: Include ELPA in README. Adapt accordingly., Stefan Monnier, 2020/03/30
- [elpa] externals/modus-operandi-theme 9ef3b88 024/112: Minor correction in README, Stefan Monnier, 2020/03/30
- [elpa] externals/modus-operandi-theme efb3ed4 022/112: Refine `font-lock-warning-face' (see commit msg),
Stefan Monnier <=
- [elpa] externals/modus-operandi-theme 7c3451e 014/112: Add support for RAINBOW-IDENTIFIERS, Stefan Monnier, 2020/03/30
- [elpa] externals/modus-operandi-theme 74431eb 012/112: Add *tentative* support for WEB-MODE (issue #17), Stefan Monnier, 2020/03/30
- [elpa] externals/modus-operandi-theme e13e565 025/112: Use more appropriate colours for HELM mode line, Stefan Monnier, 2020/03/30
- [elpa] externals/modus-operandi-theme 5b54ece 026/112: Refine HELM colours for selection and matches, Stefan Monnier, 2020/03/30
- [elpa] externals/modus-operandi-theme 8c7cce9 031/112: Tweak the colours of `helm-resume-need-update', Stefan Monnier, 2020/03/30
- [elpa] externals/modus-operandi-theme dfbc271 013/112: Add support for HIGHLIGHT-DEFINED, Stefan Monnier, 2020/03/30
- [elpa] externals/modus-operandi-theme 49e694b 016/112: Add support for FROG-MENU, Stefan Monnier, 2020/03/30
- [elpa] externals/modus-operandi-theme a8b6db6 015/112: Use fewer background colours in DIFF-MODE, Stefan Monnier, 2020/03/30
- [elpa] externals/modus-operandi-theme eb0f90a 018/112: Add EDIT-INDIRECT to list of implicitly supported, Stefan Monnier, 2020/03/30
- [elpa] externals/modus-operandi-theme d2016e7 019/112: Add `:extend t' to VOLATILE-HIGHLIGHTS (fix #19), Stefan Monnier, 2020/03/30