emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/eglot 3d480d1 01/54: Fix #259 (again): fix issue with r


From: João Távora
Subject: [elpa] externals/eglot 3d480d1 01/54: Fix #259 (again): fix issue with replace-buffer-contents
Date: Thu, 16 Apr 2020 05:31:44 -0400 (EDT)

branch: externals/eglot
commit 3d480d1989087242022be3f3efd8ef2f439417ae
Author: João Távora <address@hidden>
Commit: João Távora <address@hidden>

    Fix #259 (again): fix issue with replace-buffer-contents
    
    Manually calling the before/after change hooks for Emacs 26.1's buggy
    replace-buffer-contents must be done with absolute positions, not
    markers.
    
    * eglot.el (eglot--apply-text-edits): Call change hooks with
    buffer positions, not markers.
---
 eglot.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/eglot.el b/eglot.el
index e78d2c4..e1c7b48 100644
--- a/eglot.el
+++ b/eglot.el
@@ -2307,7 +2307,9 @@ If SKIP-SIGNATURE, don't try to send 
textDocument/signatureHelp."
                           ;; 
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=32237
                           ;; 
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=32278
                           (let ((inhibit-modification-hooks t)
-                                (length (- end beg)))
+                                (length (- end beg))
+                                (beg (marker-position beg))
+                                (end (marker-position end)))
                             (run-hook-with-args 'before-change-functions
                                                 beg end)
                             (replace-buffer-contents temp)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]