emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/eglot 7c48c7a 39/54: Document the changes in column cal


From: João Távora
Subject: [elpa] externals/eglot 7c48c7a 39/54: Document the changes in column calculation
Date: Thu, 16 Apr 2020 05:31:51 -0400 (EDT)

branch: externals/eglot
commit 7c48c7a9cf4ccf9782e8f942b53b6b682f4c0efa
Author: Felicián Németh <address@hidden>
Commit: Felicián Németh <address@hidden>

    Document the changes in column calculation
    
    * eglot.el (eglot-current-column-function)
    (eglot-move-to-column-function): Document the change of the
    default value.
    
    * NEWS.md: Log the change here as well.
---
 NEWS.md  | 9 +++++++++
 eglot.el | 8 ++++----
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/NEWS.md b/NEWS.md
index 0b4cb9e..ef6b5f3 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -1,5 +1,13 @@
 # 1.6 (upcoming)
 
+##### Column offset calculation is now LSP-conform ([#361][github#361])
+
+It seems the majority of servers now comply with the language server
+specification when it comes to handling non-ASCII texts.  Therefore
+the default values of `eglot-move-to-column-function` and
+`eglot-current-column-function` have been changed.  The documentations
+of these variables help to restore the old behavior.
+
 ##### Support workspace/configuration requests ([#326][github#326])
 
 Also a new section "Per-project server configuration" in the README.md
@@ -205,3 +213,4 @@ and now said bunch of references-->
 [github#316]: https://github.com/joaotavora/eglot/issues/316
 [github#324]: https://github.com/joaotavora/eglot/issues/324
 [github#326]: https://github.com/joaotavora/eglot/issues/326
+[github#361]: https://github.com/joaotavora/eglot/issues/361
diff --git a/eglot.el b/eglot.el
index cbfb926..5e83118 100644
--- a/eglot.el
+++ b/eglot.el
@@ -1006,8 +1006,8 @@ This is the inverse operation of
 `eglot-move-to-column-function' (which see).  It is a function of
 no arguments returning a column number.  For buffers managed by
 fully LSP-compliant servers, this should be set to
-`eglot-lsp-abiding-column', and `eglot-current-column' (the default)
-for all others.")
+`eglot-lsp-abiding-column' (the default), and
+`eglot-current-column' for all others.")
 
 (defun eglot-lsp-abiding-column ()
   "Calculate current COLUMN as defined by the LSP spec."
@@ -1033,8 +1033,8 @@ where X is a multi-byte character, it actually means `b', 
not
 `c'. However, many servers don't follow the spec this closely.
 
 For buffers managed by fully LSP-compliant servers, this should
-be set to `eglot-move-to-lsp-abiding-column', and
-`eglot-move-to-column' (the default) for all others.")
+be set to `eglot-move-to-lsp-abiding-column' (the default), and
+`eglot-move-to-column' for all others.")
 
 (defun eglot-move-to-column (column)
   "Move to COLUMN without closely following the LSP spec."



reply via email to

[Prev in Thread] Current Thread [Next in Thread]