[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/eglot 9c52f24 36/54: Fix #277: Send exit as a notificat
From: |
João Távora |
Subject: |
[elpa] externals/eglot 9c52f24 36/54: Fix #277: Send exit as a notification |
Date: |
Thu, 16 Apr 2020 05:31:51 -0400 (EDT) |
branch: externals/eglot
commit 9c52f24b4e6fccb60e96d3e68d079fa7b8e41f48
Author: Felicián Németh <address@hidden>
Commit: Felicián Németh <address@hidden>
Fix #277: Send exit as a notification
This is what the specification requires. @PerMildner, thanks for
reporting and analyzing the issue.
* eglot.el (eglot-shutdown): Use `notify' instead of `request' for the
`exit' LSP method.
---
eglot.el | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/eglot.el b/eglot.el
index e952b91..888eacc 100644
--- a/eglot.el
+++ b/eglot.el
@@ -596,11 +596,8 @@ SERVER. ."
(progn
(setf (eglot--shutdown-requested server) t)
(jsonrpc-request server :shutdown nil :timeout (or timeout 1.5))
- ;; this one is supposed to always fail, because it asks the
- ;; server to exit itself. Hence ignore-errors.
- (ignore-errors (jsonrpc-request server :exit nil :timeout 1)))
- ;; Now ask jsonrpc.el to shut down the server (which under normal
- ;; conditions should return immediately).
+ (jsonrpc-notify server :exit nil))
+ ;; Now ask jsonrpc.el to shut down the server.
(jsonrpc-shutdown server (not preserve-buffers))
(unless preserve-buffers (kill-buffer (jsonrpc-events-buffer server)))))
- [elpa] externals/eglot b0fdfb0 30/54: Close #379: add built-in support for TeX and friends, (continued)
- [elpa] externals/eglot b0fdfb0 30/54: Close #379: add built-in support for TeX and friends, João Távora, 2020/04/16
- [elpa] externals/eglot c9fcbce 32/54: Close #383: add elm-language-server as the language server for Elm, João Távora, 2020/04/16
- [elpa] externals/eglot 4b453dc 35/54: Fix #389: avoid double shutdowns and simplify shutdown logic, João Távora, 2020/04/16
- [elpa] externals/eglot 633979e 38/54: Fix #361: abide by LSP when reporting and moving to columns, João Távora, 2020/04/16
- [elpa] externals/eglot ae0943f 40/54: Revert the last change about column calculation, João Távora, 2020/04/16
- [elpa] externals/eglot e53dd5c 46/54: Per #354: make a public reader for project-nickname, João Távora, 2020/04/16
- [elpa] externals/eglot 4f6e152 51/54: Fix #430: send shutdown and exit messages without arguments, João Távora, 2020/04/16
- [elpa] externals/eglot 8332cdf 52/54: Fix eglot-move-to-lsp-abiding-column (#361), João Távora, 2020/04/16
- [elpa] externals/eglot 864a493 50/54: Close #323: add a simple github issue template, João Távora, 2020/04/16
- [elpa] externals/eglot 4496657 34/54: Close #393: use completing-read in eglot-code-actions, João Távora, 2020/04/16
- [elpa] externals/eglot 9c52f24 36/54: Fix #277: Send exit as a notification,
João Távora <=
- [elpa] externals/eglot 9f10a27 42/54: Explain the animations in the README, João Távora, 2020/04/16
- [elpa] externals/eglot e02479a 54/54: * eglot.el (Version): Bump to 1.6, João Távora, 2020/04/16
- [elpa] externals/eglot 212a7f7 43/54: Per #315: call shutdown/exit methods with params:{}, not null, João Távora, 2020/04/16
- [elpa] externals/eglot 8d8c90d 45/54: Fix #182: add public hook eglot-managed-mode-hook, João Távora, 2020/04/16
- [elpa] externals/eglot 16dd4b8 47/54: Close #414: mention eglot-find-* in README, João Távora, 2020/04/16
- [elpa] externals/eglot 2209779 49/54: Fix #425: Ignore empty hover info, João Távora, 2020/04/16
- [elpa] externals/eglot 606e234 48/54: Close #415: mention soft dependencies in README, João Távora, 2020/04/16
- [elpa] externals/eglot cacfd24 53/54: Fix #361: abide by LSP when reporting and moving to columns, João Távora, 2020/04/16