emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/modus-vivendi-theme 409648d 049/110: Refine FLYMAKE: ne


From: Stefan Monnier
Subject: [elpa] externals/modus-vivendi-theme 409648d 049/110: Refine FLYMAKE: new linter colours, better fringes
Date: Wed, 29 Apr 2020 21:40:05 -0400 (EDT)

branch: externals/modus-vivendi-theme
commit 409648deee775bdb8c7c9d4fe40b2eaa2f62c85c
Author: Protesilaos Stavrou <address@hidden>
Commit: Protesilaos Stavrou <address@hidden>

    Refine FLYMAKE: new linter colours, better fringes
    
    Flymake does not define faces for its fringe indicators, offering
    customisation options instead.  The problem with those is that they
    inherit from faces that are not necessarily optimised for the fringes
    and for the specific purpose of calling the user's attention to some
    problem in the code.  As such, we set to customise those values at the
    theme level, with the proviso that this should ideally be a standard set
    of faces provided by Flymake.
    
    For more on the new linter colours, see commit 53e1a43.
---
 modus-operandi-theme.el | 10 +++++++---
 modus-vivendi-theme.el  | 10 +++++++---
 2 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/modus-operandi-theme.el b/modus-operandi-theme.el
index cf00d9a..dc531f3 100644
--- a/modus-operandi-theme.el
+++ b/modus-operandi-theme.el
@@ -1427,9 +1427,9 @@ AMOUNT is a customisation option."
    `(flycheck-posframe-info-face ((,class (:foreground ,cyan :weight bold))))
    `(flycheck-posframe-warning-face ((,class (:foreground ,yellow :weight 
bold))))
    ;;;; flymake
-   `(flymake-error ((,class (:foreground ,red :underline t))))
-   `(flymake-note ((,class (:foreground ,green :underline t))))
-   `(flymake-warning ((,class (:foreground ,yellow :underline t))))
+   `(flymake-error ((,class (:foreground ,red-nuanced :underline (:color 
,fg-lang-error :style line)))))
+   `(flymake-note ((,class (:foreground ,blue-nuanced :underline (:color 
,fg-lang-note :style line)))))
+   `(flymake-warning ((,class (:foreground ,yellow-nuanced :underline (:color 
,fg-lang-warning :style line)))))
    ;;;; flyspell
    `(flyspell-duplicate
      ((,(append '((supports :underline (:style wave))) class)
@@ -3001,6 +3001,10 @@ AMOUNT is a customisation option."
     ;;;; ansi-colors
     `(ansi-color-faces-vector [default bold shadow italic underline success 
warning error])
     `(ansi-color-names-vector [,fg-main ,red ,green ,yellow ,blue ,magenta 
,cyan ,bg-main])
+    ;;;; flymake fringe indicators
+    `(flymake-error-bitmap '(flymake-double-exclamation-mark 
modus-theme-fringe-red))
+    `(flymake-warning-bitmap '(exclamation-mark modus-theme-fringe-yellow))
+    `(flymake-note-bitmap '(exclamation-mark modus-theme-fringe-cyan))
     ;;;; ibuffer
     `(ibuffer-deletion-face 'dired-flagged)
     `(ibuffer-filter-group-name-face 'dired-mark)
diff --git a/modus-vivendi-theme.el b/modus-vivendi-theme.el
index c74286b..893bded 100644
--- a/modus-vivendi-theme.el
+++ b/modus-vivendi-theme.el
@@ -1427,9 +1427,9 @@ AMOUNT is a customisation option."
    `(flycheck-posframe-info-face ((,class (:foreground ,cyan :weight bold))))
    `(flycheck-posframe-warning-face ((,class (:foreground ,yellow :weight 
bold))))
    ;;;; flymake
-   `(flymake-error ((,class (:foreground ,red :underline t))))
-   `(flymake-note ((,class (:foreground ,green :underline t))))
-   `(flymake-warning ((,class (:foreground ,yellow :underline t))))
+   `(flymake-error ((,class (:foreground ,red-nuanced :underline (:color 
,fg-lang-error :style line)))))
+   `(flymake-note ((,class (:foreground ,blue-nuanced :underline (:color 
,fg-lang-note :style line)))))
+   `(flymake-warning ((,class (:foreground ,yellow-nuanced :underline (:color 
,fg-lang-warning :style line)))))
    ;;;; flyspell
    `(flyspell-duplicate
      ((,(append '((supports :underline (:style wave))) class)
@@ -3001,6 +3001,10 @@ AMOUNT is a customisation option."
     ;;;; ansi-colors
     `(ansi-color-faces-vector [default bold shadow italic underline success 
warning error])
     `(ansi-color-names-vector [,bg-main ,red ,green ,yellow ,blue ,magenta 
,cyan ,fg-main])
+    ;;;; flymake fringe indicators
+    `(flymake-error-bitmap '(flymake-double-exclamation-mark 
modus-theme-fringe-red))
+    `(flymake-warning-bitmap '(exclamation-mark modus-theme-fringe-yellow))
+    `(flymake-note-bitmap '(exclamation-mark modus-theme-fringe-cyan))
     ;;;; ibuffer
     `(ibuffer-deletion-face 'dired-flagged)
     `(ibuffer-filter-group-name-face 'dired-mark)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]