emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] master 535349a 6/6: Excorporate: Rename a function


From: Thomas Fitzsimmons
Subject: [elpa] master 535349a 6/6: Excorporate: Rename a function
Date: Fri, 25 Sep 2020 22:32:45 -0400 (EDT)

branch: master
commit 535349a93df8eede61c666bebb0041f20fec541f
Author: Thomas Fitzsimmons <fitzsim@fitzsim.org>
Commit: Thomas Fitzsimmons <fitzsim@fitzsim.org>

    Excorporate: Rename a function
    
    * packages/excorporate/excorporate.el
    (exco-resolve-organizer-email-address-synchronously): Rename from
    exco-organizer-smtp-email-address.
    * packages/excorporate/excorporate-org.el
    (exco-org-insert-meetings): Use
    exco-resolve-organizer-email-address-synchronously.
---
 packages/excorporate/excorporate-org.el |  2 +-
 packages/excorporate/excorporate.el     | 18 ++++++++++--------
 2 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/packages/excorporate/excorporate-org.el 
b/packages/excorporate/excorporate-org.el
index b7c1b76..6499dc8 100644
--- a/packages/excorporate/excorporate-org.el
+++ b/packages/excorporate/excorporate-org.el
@@ -311,7 +311,7 @@ meeting organizer."
                    (org-mode)
                    (let ((new-arguments arguments))
                      (setf (nth 7 new-arguments)
-                           (exco-organizer-smtp-email-address
+                           (exco-resolve-organizer-email-address-synchronously
                             identifier organizer-structure))
                      (apply #'exco-org-insert-meeting new-arguments))))
        subject start-internal end-internal
diff --git a/packages/excorporate/excorporate.el 
b/packages/excorporate/excorporate.el
index b068121..b9d1748 100644
--- a/packages/excorporate/excorporate.el
+++ b/packages/excorporate/excorporate.el
@@ -865,17 +865,19 @@ argument ICALENDAR-TEXT."
                                                  mime-path response)))
                                           coding-system))))))
 
-;; The organizer email is in the server's internal "EX" format.
-;; Resolve it synchronously, for simplicity.
-(defun exco-organizer-smtp-email-address (identifier organizer-structure)
+;; The organizer email address is in some cases returned in the
+;; server's internal "EX" format which is very long and unfamiliar.
+;; If necessary resolve it to the "SMTP" format.  This is done
+;; synchronously, for simplicity.
+(defun exco-resolve-organizer-email-address-synchronously (identifier
+                                                          organizer-structure)
   "Return the organizer's SMTP email address as a string.
 IDENTIFIER is the connection identifier to use to resolve
 ORGANIZER-STRUCTURE to the returned value.  ORGANIZER-STRUCTURE
-should be treated as opaque.
-
-This function queries the server synchronously.  It times out and
-returns nil if the server does not respond in under
-`exco--server-timeout' seconds."
+should be treated as opaque.  If the address is not already an
+SMTP address, then this function queries the server synchronously
+to resolve the SMTP address.  It times out and returns nil if the
+server does not respond in under `exco--server-timeout' seconds."
   (let* ((wrapped (list (list organizer-structure)))
         (routing-type
          (exco-extract-value '(Organizer Mailbox RoutingType) wrapped))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]