emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/webfeeder d12b352 1/2: Revert "Escape author, title and


From: Pierre Neidhardt
Subject: [elpa] externals/webfeeder d12b352 1/2: Revert "Escape author, title and subtitle for XML special characters.".
Date: Mon, 23 Nov 2020 11:09:20 -0500 (EST)

branch: externals/webfeeder
commit d12b35221349c08190de87bdd0617f2dcfc0a235
Author: Pierre Neidhardt <mail@ambrevar.xyz>
Commit: Pierre Neidhardt <mail@ambrevar.xyz>

    Revert "Escape author, title and subtitle for XML special characters.".
    
    It should not be needed and indeed breaks emails in the form 
"<foo@example.org>"
    or special characters in titles or subtitles.
---
 webfeeder.el | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/webfeeder.el b/webfeeder.el
index cfc2192..c23cac6 100644
--- a/webfeeder.el
+++ b/webfeeder.el
@@ -412,12 +412,14 @@ variables:
   (cl-loop for html-file in html-files
            for dest = (expand-file-name html-file project-dir)
            for feed-url = (concat (replace-regexp-in-string "/*$" "" url) "/" 
html-file)
-           for feed-author = (webfeeder--xml-escape-string (funcall 
webfeeder-author-function dest))
+           ;; TODO: Shall we escape author, title and subtitle?  HTML files
+           ;; should already be escaped, so there should be no need.
+           for feed-author = (funcall webfeeder-author-function dest)
            for feed-date = (or (funcall webfeeder-date-function
                                         (expand-file-name html-file 
project-dir))
                                0)
-           for feed-title = (or (webfeeder--xml-escape-string (funcall 
webfeeder-title-function dest)) feed-url)
-           for feed-subtitle = (webfeeder--xml-escape-string (funcall 
webfeeder-subtitle-function dest))
+           for feed-title = (or (funcall webfeeder-title-function dest) 
feed-url)
+           for feed-subtitle = (funcall webfeeder-subtitle-function dest)
            for feed-body = (funcall webfeeder-body-function dest feed-url 
'exclude-toc)
            for feed-categories = (funcall webfeeder-categories-function dest)
            for feed-generator = (funcall webfeeder-generator-function dest)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]