emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/js2-mode 474c396 2/2: * packages/gnome-c-style/gnome-c-


From: Stefan Monnier
Subject: [elpa] externals/js2-mode 474c396 2/2: * packages/gnome-c-style/gnome-c-tests.el: Add copyright blurb
Date: Fri, 27 Nov 2020 19:07:01 -0500 (EST)

branch: externals/js2-mode
commit 474c3961a8863dfc72f2fd951ed6b78aa140cb36
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>

    * packages/gnome-c-style/gnome-c-tests.el: Add copyright blurb
---
 js2-mode.el | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/js2-mode.el b/js2-mode.el
index 09dd91a..3f789fa 100644
--- a/js2-mode.el
+++ b/js2-mode.el
@@ -11615,18 +11615,13 @@ highlighting features of `js2-mode'."
     map)
   "Keymap used for js2 diagnostics buffers.")
 
-(defun js2-error-buffer-mode ()
+(define-derived-mode js2-error-buffer-mode special-mode "JS Lint Diagnostics"
   "Major mode for js2 diagnostics buffers.
 Selecting an error will jump it to the corresponding source-buffer error.
 \\{js2-error-buffer-mode-map}"
-  (interactive)
-  (setq major-mode 'js2-error-buffer-mode
-        mode-name "JS Lint Diagnostics")
-  (use-local-map js2-error-buffer-mode-map)
   (setq truncate-lines t)
   (set-buffer-modified-p nil)
-  (setq buffer-read-only t)
-  (run-hooks 'js2-error-buffer-mode-hook))
+  (setq buffer-read-only t))
 
 (defun js2-error-buffer-next ()
   "Move to next error and view it."
@@ -11655,7 +11650,7 @@ Selecting an error will jump it to the corresponding 
source-buffer error.
   "Scroll source buffer to show error at current line."
   (interactive)
   (cond
-   ((not (eq major-mode 'js2-error-buffer-mode))
+   ((not (derived-mode-p 'js2-error-buffer-mode))
     (message "Not in a js2 errors buffer"))
    ((not (buffer-live-p js2-source-buffer))
     (message "Source buffer has been killed"))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]