emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/gnorb 8121bf5 188/449: Stop creating hash table entries


From: Stefan Monnier
Subject: [elpa] externals/gnorb 8121bf5 188/449: Stop creating hash table entries and GNORB_MSG_IDS
Date: Fri, 27 Nov 2020 23:15:36 -0500 (EST)

branch: externals/gnorb
commit 8121bf5d40f53a5467b9bb3ce50501f15415eafc
Author: Eric Abrahamsen <eric@ericabrahamsen.net>
Commit: Eric Abrahamsen <eric@ericabrahamsen.net>

    Stop creating hash table entries and GNORB_MSG_IDS
    
    Preparatory to removing the hash table altogether, we stop creating hash
    table entries, or saving the message ids of outgoing messages in Org
    heading properties.
    
    * lisp/gnorb-utils.el (gnorb-trigger-todo-action): Only create registry
      entries, not hash table entries.
    
    * lisp/gnorb-org.el (gnorb-org-msg-id-key): Note this fact in the
      docstring of this (soon to be removed) customization option.
---
 lisp/gnorb-org.el   | 3 ++-
 lisp/gnorb-utils.el | 5 +----
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/lisp/gnorb-org.el b/lisp/gnorb-org.el
index 36822a5..fedf61f 100644
--- a/lisp/gnorb-org.el
+++ b/lisp/gnorb-org.el
@@ -48,7 +48,8 @@ org-todo regardless of TODO type."
 
 (defcustom gnorb-org-msg-id-key "GNORB_MSG_ID"
   "The name of the org property used to store the Message-IDs
-  from relevant messages."
+  from relevant messages. This is no longer used, and will be
+  removed soon."
   :group 'gnorb-org
   :type 'string)
 
diff --git a/lisp/gnorb-utils.el b/lisp/gnorb-utils.el
index 669763f..4916910 100644
--- a/lisp/gnorb-utils.el
+++ b/lisp/gnorb-utils.el
@@ -143,15 +143,12 @@ the prefix arg."
                root-marker gnorb-org-msg-id-key))
          (sent-id (plist-get gnorb-gnus-sending-message-info :msg-id)))
       (when sent-id
-       (org-entry-add-to-multivalued-property
-        root-marker gnorb-org-msg-id-key sent-id)
        (gnorb-registry-make-entry
         sent-id
         (plist-get gnorb-gnus-sending-message-info :from)
         (plist-get gnorb-gnus-sending-message-info :subject)
         (org-id-get)
-        (plist-get gnorb-gnus-sending-message-info :group))
-       (gnorb-org-add-id-hash-entry sent-id root-marker))
+        (plist-get gnorb-gnus-sending-message-info :group)))
       (setq action (cond ((not
                           (or (and ret-dest-todo
                                    (null gnorb-org-mail-todos))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]