emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/gnorb b6ab1c5 214/449: Only use the summary reply hook


From: Stefan Monnier
Subject: [elpa] externals/gnorb b6ab1c5 214/449: Only use the summary reply hook once.
Date: Fri, 27 Nov 2020 23:15:42 -0500 (EST)

branch: externals/gnorb
commit b6ab1c55ecab2fd49311860631a5d34b5b17e432
Author: Eric Abrahamsen <eric@ericabrahamsen.net>
Commit: Eric Abrahamsen <eric@ericabrahamsen.net>

    Only use the summary reply hook once.
    
    Most of the functions shadowing Gnus' reply functions simply call into
    gnorb-summary-reply. Don't call gnorb-summary-reply-hook if it's going
    to get called again later! Pure brain-o.
    
    * lisp/nngnorb.el (gnorb-summary-wide-reply,
      gnorb-summary-reply-with-original, gnorb-summary-very-wide-reply,
      gnorb-summary-wide-reply-with-original,
      gnorb-summary-very-wide-reply-with-original): None of these need to
      call the hook.
---
 lisp/nngnorb.el | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/lisp/nngnorb.el b/lisp/nngnorb.el
index 165397c..864c78d 100644
--- a/lisp/nngnorb.el
+++ b/lisp/nngnorb.el
@@ -204,20 +204,17 @@ continue to provide tracking of sent messages."
   (interactive
    (list (and current-prefix-arg
              (gnus-summary-work-articles 1))))
-  (gnorb-summary-reply yank t)
-  (gnorb-summary-reply-hook))
+  (gnorb-summary-reply yank t))
 
 (defun gnorb-summary-reply-with-original (n &optional wide)
   (interactive "P")
-  (gnorb-summary-reply (gnus-summary-work-articles n) wide)
-  (gnorb-summary-reply-hook))
+  (gnorb-summary-reply (gnus-summary-work-articles n) wide))
 
 (defun gnorb-summary-very-wide-reply (&optional yank)
   (interactive
    (list (and current-prefix-arg
              (gnus-summary-work-articles 1))))
-  (gnorb-summary-reply yank t (gnus-summary-work-articles yank))
-  (gnorb-summary-reply-hook))
+  (gnorb-summary-reply yank t (gnus-summary-work-articles yank)))
 
 (defun gnorb-summary-reply (&optional yank wide very-wide)
   (interactive)
@@ -226,14 +223,12 @@ continue to provide tracking of sent messages."
 
 (defun gnorb-summary-wide-reply-with-original (n)
   (interactive "P")
-  (gnorb-summary-reply-with-original n t)
-  (gnorb-summary-reply-hook))
+  (gnorb-summary-reply-with-original n t))
 
 (defun gnorb-summary-very-wide-reply-with-original (n)
   (interactive "P")
   (gnorb-summary-reply
-   (gnus-summary-work-articles n) t (gnus-summary-work-articles n))
-  (gnorb-summary-reply-hook))
+   (gnus-summary-work-articles n) t (gnus-summary-work-articles n)))
 
 (defun gnorb-summary-mail-forward (n)
   (interactive "P")



reply via email to

[Prev in Thread] Current Thread [Next in Thread]