[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/gnorb d754d2f 336/449: Fixing `gnorb-bbdb-postings-styl
From: |
Stefan Monnier |
Subject: |
[elpa] externals/gnorb d754d2f 336/449: Fixing `gnorb-bbdb-postings-styles' |
Date: |
Fri, 27 Nov 2020 23:16:06 -0500 (EST) |
branch: externals/gnorb
commit d754d2f220815a804aabe4707835a7bdbef14e77
Author: Eric Abrahamsen <eric@ericabrahamsen.net>
Commit: Eric Abrahamsen <eric@ericabrahamsen.net>
Fixing `gnorb-bbdb-postings-styles'
* gnorb-bbdb.el (gnorb-bbdb-configure-posting-styles): Hard to know what
I was thinking when I wrote this, that's not how you use throw/catch
at all. Luckily no one seems to be using this part of the code. And
why would they? It doesn't make a whole lot of sense.
---
gnorb-bbdb.el | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/gnorb-bbdb.el b/gnorb-bbdb.el
index cb19aee..306ea01 100644
--- a/gnorb-bbdb.el
+++ b/gnorb-bbdb.el
@@ -258,31 +258,31 @@ is non-nil (as in interactive calls) be verbose."
(when (catch 'match
(cond
((eq field 'address)
- (dolist (a rec-val matchp)
+ (dolist (a rec-val)
(unless (and label
(not (string-match label (car a))))
(when
(string-match-p
val
(bbdb-format-address-default a))
- (throw 'match)))))
+ (throw 'match t)))))
((eq field 'phone)
- (dolist (p rec-val matchp)
+ (dolist (p rec-val)
(unless (and label
(not (string-match label (car p))))
(when
(string-match-p val (bbdb-phone-string p))
- (throw 'match)))))
+ (throw 'match t)))))
((consp rec-val)
- (dolist (f rec-val matchp)
+ (dolist (f rec-val)
(when (string-match-p val f)
- (throw 'match))))
+ (throw 'match t))))
((fboundp field)
- (when (matchp (funcall field r))
- (throw 'match)))
+ (when (string-match-p (funcall field r))
+ (throw 'match t)))
((stringp rec-val)
(when (string-match-p val rec-val)
- (throw 'match)))))
+ (throw 'match t)))))
;; there are matches, run through the field setters in last
;; element of the sexp
(dolist (attribute style)
- [elpa] externals/gnorb aa8d041 350/449: Mention 'all option in gnorb-org-mail-scan-scope, (continued)
- [elpa] externals/gnorb aa8d041 350/449: Mention 'all option in gnorb-org-mail-scan-scope, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 06b0e09 351/449: Update to match new version of BBDB, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 16931d7 352/449: New utility function gnorb-select-from-list, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb c8521d4 156/449: gnorb-org-mail-todos should be nil by default, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb aedf0f2 169/449: Show status of relevant todo when hinting messages, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 67edd80 239/449: Use mail-header-references, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb dfa0043 300/449: Safer usage of cl-subseq, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 2d30b0c 310/449: Reset window conf after nnir-run-gnorb, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb a59dac2 317/449: Use hook for determining Gnorb summary minor mode, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 7fcde77 328/449: Handle renaming of Org variable, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb d754d2f 336/449: Fixing `gnorb-bbdb-postings-styles',
Stefan Monnier <=
- [elpa] externals/gnorb 984d5e6 338/449: gnorb-org.el: Don't use nreverse, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 7ea06f9 339/449: Delete gnorb-prompt-for-bbdb-record, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb e2afc4b 355/449: Switch on lexical binding across the board, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 7d14112 358/449: Trying to fix issue #30., Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb c1014ac 359/449: Merge pull request #31 from berhoel/master, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 64e72d6 360/449: Use :package-version, not :version, on defcustom, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 3090162 361/449: Bump version to 1.1.4, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb c0b3090 362/449: Fix email subtree command, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 6cdf064 365/449: Remove useless use of progn, update usage status function, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 6a3ea57 368/449: Update documentation, Stefan Monnier, 2020/11/27