[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/vlf e545769 128/310: Fix adjusting of end chunk bytes.
From: |
Stefan Monnier |
Subject: |
[elpa] externals/vlf e545769 128/310: Fix adjusting of end chunk bytes. |
Date: |
Sat, 28 Nov 2020 00:33:00 -0500 (EST) |
branch: externals/vlf
commit e5457690fb7d7bd288e63b7f3fea1f85d037e320
Author: Andrey Kotlarski <m00naticus@gmail.com>
Commit: Andrey Kotlarski <m00naticus@gmail.com>
Fix adjusting of end chunk bytes.
---
vlfi.el | 87 ++++++++++++++++++++++++++++++++++++++++-------------------------
1 file changed, 54 insertions(+), 33 deletions(-)
diff --git a/vlfi.el b/vlfi.el
index e2af046..b970d1e 100644
--- a/vlfi.el
+++ b/vlfi.el
@@ -299,12 +299,14 @@ When given MINIMAL flag, skip non important operations."
"Move to chunk determined by START END.
When given MINIMAL flag, skip non important operations."
(vlfi-verify-size)
- (and (vlfi-move-to-chunk-1 start end)
- (not minimal)
- (vlfi-update-buffer-name)))
+ (if (buffer-modified-p)
+ (if (vlfi-move-to-chunk-1 start end)
+ (or minimal (vlfi-update-buffer-name)))
+ (vlfi-move-to-chunk-2 start end)
+ (or minimal (vlfi-update-buffer-name))))
(defun vlfi-move-to-chunk-1 (start end)
- "Move to chunk determined by START END keeping as much changes.
+ "Move to chunk determined by START END keeping as much edits.
Return t if move hasn't been canceled."
(let ((modified (buffer-modified-p))
(start (max 0 start))
@@ -328,8 +330,9 @@ Return t if move hasn't been canceled."
(shift-end 0)
(inhibit-read-only t))
(cond ((< end edit-end)
- (delete-region (byte-to-position (- end
- vlfi-start-pos))
+ (delete-region (byte-to-position (1+
+ (- end
+ vlfi-start-pos)))
(point-max)))
((< edit-end end)
(let ((edit-end-pos (point-max)))
@@ -337,7 +340,7 @@ Return t if move hasn't been canceled."
(insert-file-contents buffer-file-name nil
vlfi-end-pos end)
(setq shift-end (cdr (vlfi-adjust-chunk
- vlfi-end-pos end
+ vlfi-end-pos end nil t
edit-end-pos))))))
(cond ((< vlfi-start-pos start)
(delete-region (point-min) (byte-to-position
@@ -350,12 +353,13 @@ Return t if move hasn't been canceled."
(setq shift-start (car
(vlfi-adjust-chunk start
vlfi-start-pos
+ t nil
edit-end-pos)))
(goto-char (point-min))
(insert (delete-and-extract-region edit-end-pos
(point-max))))))
(setq vlfi-start-pos (- start shift-start)
- vlfi-end-pos (- end shift-end))
+ vlfi-end-pos (+ end shift-end))
(goto-char (or (byte-to-position (- pos vlfi-start-pos))
(point-max))))
(set-buffer-modified-p modified)
@@ -370,41 +374,58 @@ Return t if move hasn't been canceled."
(erase-buffer)
(insert-file-contents buffer-file-name nil
vlfi-start-pos vlfi-end-pos)
- (let ((shifts (vlfi-adjust-chunk vlfi-start-pos vlfi-end-pos)))
+ (let ((shifts (vlfi-adjust-chunk vlfi-start-pos vlfi-end-pos t
+ t)))
(setq vlfi-start-pos (- vlfi-start-pos (car shifts))
- vlfi-end-pos (- vlfi-end-pos (cdr shifts)))
+ vlfi-end-pos (+ vlfi-end-pos (cdr shifts)))
(goto-char (or (byte-to-position (+ pos (car shifts)))
(point-max)))))
(set-buffer-modified-p nil)
(set-visited-file-modtime))
-(defun vlfi-adjust-chunk (start end &optional position)
- "Adjust chunk at absolute START till END until content can be \
-properly decoded. Use buffer POSITION as start if given.
+(defun vlfi-adjust-chunk (start end &optional adjust-start adjust-end
+ position)
+ "Adjust chunk at absolute START to END till content can be \
+properly decoded. ADJUST-START determines if trying to prepend bytes\
+ to the beginning, ADJUST-END - add to the end.
+Use buffer POSITION as start if given.
Return number of bytes moved back for proper decoding and number of
-bytes striped from the end character."
+bytes added to the end."
(let ((position (or position (point-min)))
(shift-start 0)
(shift-end 0)
(chunk-size (- end start)))
- (while (and (not (zerop start))
- (< shift-start 4)
- (< 4 (abs (- chunk-size
- (length (encode-coding-region
- position (point-max)
- buffer-file-coding-system
- t))))))
- (setq shift-start (1+ shift-start)
- start (1- start)
- chunk-size (1+ chunk-size))
- (delete-region position (point-max))
- (goto-char position)
- (insert-file-contents buffer-file-name nil start end))
- (if (< end vlfi-file-size)
- (let ((point-max (point-max)))
- (setq shift-end (- (position-bytes point-max)
- (position-bytes (1- point-max))))
- (delete-region (1- point-max) point-max))) ;delete last character,
may be incomplete
+ ;; adjust beginning
+ (if adjust-start
+ (while (and (not (zerop start))
+ (< shift-start 4)
+ (< 4 (abs (- chunk-size
+ (length (encode-coding-region
+ position (point-max)
+ buffer-file-coding-system
+ t))))))
+ (setq shift-start (1+ shift-start)
+ start (1- start)
+ chunk-size (1+ chunk-size))
+ (delete-region position (point-max))
+ (goto-char position)
+ (insert-file-contents buffer-file-name nil start end)))
+ ;; adjust end
+ (when (and adjust-end (< end vlfi-file-size))
+ (let ((expected-size (buffer-size)))
+ (while (and (= expected-size (buffer-size))
+ (< end vlfi-file-size))
+ (setq shift-end (1+ shift-end)
+ end (1+ end))
+ (delete-region position (point-max))
+ (goto-char position)
+ (insert-file-contents buffer-file-name nil start end)))
+ (when (< end vlfi-file-size)
+ (setq shift-end (1- shift-end)
+ end (1- end))
+ (delete-region position (point-max))
+ (goto-char position)
+ (insert-file-contents buffer-file-name nil start end)))
(cons shift-start shift-end)))
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
@@ -805,7 +826,7 @@ Save anyway? ")))
((< 0 size-change)
(vlfi-file-shift-back size-change))
(t (vlfi-file-shift-forward (- size-change))))
- (vlfi-move-to-chunk vlfi-start-pos vlfi-end-pos)
+ (vlfi-move-to-chunk-2 vlfi-start-pos vlfi-end-pos)
(goto-char pos))
(vlfi-mode))
t)
- [elpa] externals/vlf 1948f3e 041/310: Make VLFI edit mode actually working., (continued)
- [elpa] externals/vlf 1948f3e 041/310: Make VLFI edit mode actually working., Stefan Monnier, 2020/11/28
- [elpa] externals/vlf 5405a30 045/310: Intercept buffer saving with vlfi-write., Stefan Monnier, 2020/11/28
- [elpa] externals/vlf f3132c0 044/310: Keep current position when moving around chunks., Stefan Monnier, 2020/11/28
- [elpa] externals/vlf 8787186 055/310: Show paging according to batch size instead of percentage., Stefan Monnier, 2020/11/28
- [elpa] externals/vlf 8f6299c 056/310: Simplify detection of buffer size change., Stefan Monnier, 2020/11/28
- [elpa] externals/vlf f23262e 057/310: Add shift back of file contents when edited chunk shrinks in size., Stefan Monnier, 2020/11/28
- [elpa] externals/vlf 2f201c5 061/310: Add jump to chunk command., Stefan Monnier, 2020/11/28
- [elpa] externals/vlf d5f2a36 060/310: Rearrange code in sections., Stefan Monnier, 2020/11/28
- [elpa] externals/vlf 705f9ce 064/310: Add issue section to the README., Stefan Monnier, 2020/11/28
- [elpa] externals/vlf 9fad430 066/310: Fix positioning after save., Stefan Monnier, 2020/11/28
- [elpa] externals/vlf e545769 128/310: Fix adjusting of end chunk bytes.,
Stefan Monnier <=
- [elpa] externals/vlf ae2237d 135/310: Minor adjustments:, Stefan Monnier, 2020/11/28
- [elpa] externals/vlf cb47e19 139/310: Use temporary buffer for occur in case of modifications., Stefan Monnier, 2020/11/28
- [elpa] externals/vlf 7a14109 137/310: Fix search for GNU Emacs 23 (no assert)., Stefan Monnier, 2020/11/28
- [elpa] externals/vlf 452b7eb 141/310: Ensure there are no modifications when executing searches., Stefan Monnier, 2020/11/28
- [elpa] externals/vlf a42247c 150/310: Automatically scroll to adjacent batch when start or end of chunk is, Stefan Monnier, 2020/11/28
- [elpa] externals/vlf 959bbc7 155/310: Disable undo in cases of partial chunk move., Stefan Monnier, 2020/11/28
- [elpa] externals/vlf a65f3a4 143/310: Check for unsaved changes before search query and don't enable undo if, Stefan Monnier, 2020/11/28
- [elpa] externals/vlf 42e581d 144/310: Add command to unconditionally open fresh VLF buffer to visit occur, Stefan Monnier, 2020/11/28
- [elpa] externals/vlf 3e8098a 149/310: Rename vlf-discard-edit -> vlf-refresh., Stefan Monnier, 2020/11/28
- [elpa] externals/vlf c0a85cd 159/310: Fix position when moving to overlapping chunk., Stefan Monnier, 2020/11/28