[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/undo-tree f3e7324 090/195: Use undo-tree-inhibit-kill-v
From: |
Stefan Monnier |
Subject: |
[elpa] externals/undo-tree f3e7324 090/195: Use undo-tree-inhibit-kill-visualizer to inhibit undo-tree-kill-visualizer. |
Date: |
Sat, 28 Nov 2020 13:41:28 -0500 (EST) |
branch: externals/undo-tree
commit f3e7324c740abcf695f58f711b0407532a4de6f8
Author: Toby S. Cubitt <toby-undo-tree@dr-qubit.org>
Commit: Toby S. Cubitt <toby-undo-tree@dr-qubit.org>
Use undo-tree-inhibit-kill-visualizer to inhibit undo-tree-kill-visualizer.
Previously, we used a non-nil undo-in-progress for this purpose, but that
meant that the visualizer wasn't killed on an undo or redo in the parent
buffer.
---
undo-tree.el | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/undo-tree.el b/undo-tree.el
index 7f01755..ce94d78 100644
--- a/undo-tree.el
+++ b/undo-tree.el
@@ -618,6 +618,9 @@
;; * make various interactive commands signal an error if buffer is read-only
;; * let-bind `inhibit-read-only' instead of setting and restoring
;; `buffer-read-only'
+;; * use non-nil `undo-tree-inhibit-kill-visualizer' instead of
+;; `undo-in-progress' to inhibit `undo-tree-kill-visualizer', so that
+;; undoing and redoing in parent buffer also kill visualizer
;;
;; Version 0.3.5
;; * improved `undo-tree-switch-branch': display current branch number in
@@ -863,6 +866,10 @@ in visualizer."
(defconst undo-tree-visualizer-buffer-name " *undo-tree*")
+;; dynamically bound to t when undoing from visualizer, to inhibit
+;; `undo-tree-kill-visualizer' hook function in parent buffer
+(defvar undo-tree-inhibit-kill-visualizer nil)
+
;; prevent debugger being called on "No further redo information"
(add-to-list 'debug-ignored-errors "^No further redo information")
@@ -2863,7 +2870,7 @@ signaling an error if file is not found."
(defun undo-tree-kill-visualizer (&rest dummy)
;; Kill visualizer. Added to `before-change-functions' hook of original
;; buffer when visualizer is invoked.
- (unless undo-in-progress
+ (unless undo-tree-inhibit-kill-visualizer
(unwind-protect
(with-current-buffer undo-tree-visualizer-buffer-name
(undo-tree-visualizer-quit)))))
@@ -3203,7 +3210,7 @@ Within the undo-tree visualizer, the following keys are
available:
(switch-to-buffer-other-window undo-tree-visualizer-parent-buffer)
(deactivate-mark)
(unwind-protect
- (undo-tree-undo arg)
+ (let ((undo-tree-inhibit-kill-visualizer t)) (undo-tree-undo arg))
(switch-to-buffer-other-window undo-tree-visualizer-buffer-name)
(let ((inhibit-read-only t))
(undo-tree-draw-node (undo-tree-current buffer-undo-tree) 'current))))
@@ -3218,7 +3225,7 @@ Within the undo-tree visualizer, the following keys are
available:
(switch-to-buffer-other-window undo-tree-visualizer-parent-buffer)
(deactivate-mark)
(unwind-protect
- (undo-tree-redo arg)
+ (let ((undo-tree-inhibit-kill-visualizer t)) (undo-tree-redo arg))
(switch-to-buffer-other-window undo-tree-visualizer-buffer-name)
(goto-char (undo-tree-node-marker (undo-tree-current buffer-undo-tree)))
(let ((inhibit-read-only t))
@@ -3285,7 +3292,7 @@ at POS, or point if POS is nil."
(when node
;; set parent buffer to state corresponding to node at POS
(set-buffer undo-tree-visualizer-parent-buffer)
- (undo-tree-set node)
+ (let ((undo-tree-inhibit-kill-visualizer t)) (undo-tree-set node))
(set-buffer undo-tree-visualizer-buffer-name)
;; re-draw undo tree
(let ((inhibit-read-only t)) (undo-tree-draw-tree buffer-undo-tree)))))
- [elpa] externals/undo-tree e01a3e7 191/195: Fix some byte-compilation warnings., (continued)
- [elpa] externals/undo-tree e01a3e7 191/195: Fix some byte-compilation warnings., Stefan Monnier, 2020/11/28
- [elpa] externals/undo-tree 17454bd 084/195: Improved undo-tree-switch-branch behaviour., Stefan Monnier, 2020/11/28
- [elpa] externals/undo-tree f16ab5f 067/195: Trivial fix in Commentary., Stefan Monnier, 2020/11/28
- [elpa] externals/undo-tree e8215a7 078/195: Minor typo fixes in comments., Stefan Monnier, 2020/11/28
- [elpa] externals/undo-tree 8697a0b 077/195: Clear registers referring to nodes being discarded from undo history., Stefan Monnier, 2020/11/28
- [elpa] externals/undo-tree f956d55 074/195: Added autoload cookies, and other tweaks to prepare for ELPA packaging., Stefan Monnier, 2020/11/28
- [elpa] externals/undo-tree 4e558f8 088/195: Make various interactive commands signal an error if buffer is read-only., Stefan Monnier, 2020/11/28
- [elpa] externals/undo-tree e001bd5 091/195: Implemented diff display in visualizer., Stefan Monnier, 2020/11/28
- [elpa] externals/undo-tree 1229460 095/195: Make visualizer diff buffer name into a defconst., Stefan Monnier, 2020/11/28
- [elpa] externals/undo-tree 7fef53f 092/195: Display diff with current node in visualizer selection mode., Stefan Monnier, 2020/11/28
- [elpa] externals/undo-tree f3e7324 090/195: Use undo-tree-inhibit-kill-visualizer to inhibit undo-tree-kill-visualizer.,
Stefan Monnier <=
- [elpa] externals/undo-tree bb92692 093/195: Don't override diff-switches customization option in visualizer diff display., Stefan Monnier, 2020/11/28
- [elpa] externals/undo-tree a220a42 097/195: Added registerv-make and registerv-data compatibility macros in Emacs <= 23., Stefan Monnier, 2020/11/28
- [elpa] externals/undo-tree 95599db 100/195: Fixed bug in visualizer selection mode when timestamps are displayed., Stefan Monnier, 2020/11/28
- [elpa] externals/undo-tree 81f1417 098/195: Added diff-no-select and diff-file-local-copy compatibility hacks, Stefan Monnier, 2020/11/28
- [elpa] externals/undo-tree aa7202c 103/195: Fix the way keymaps are defined., Stefan Monnier, 2020/11/28
- [elpa] externals/undo-tree e69adb3 109/195: Remove now unnecessary compatibility hack for called-interactively-p., Stefan Monnier, 2020/11/28
- [elpa] externals/undo-tree 00ffbb6 121/195: Bump version number below which we warn against enabling persistent storage., Stefan Monnier, 2020/11/28
- [elpa] externals/undo-tree 5df6374 128/195: Switch to lexical binding., Stefan Monnier, 2020/11/28
- [elpa] externals/undo-tree 9b55464 126/195: Make undo history filename match docs., Stefan Monnier, 2020/11/28
- [elpa] externals/undo-tree f566beb 106/195: Add customization option allowing timestamps to be displayed by default, Stefan Monnier, 2020/11/28