emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/metar 8c6596d 03/16: * packages/metar/metar.el (metar-l


From: Stefan Monnier
Subject: [elpa] externals/metar 8c6596d 03/16: * packages/metar/metar.el (metar-latitude-longitude-distance-haversine):
Date: Sat, 28 Nov 2020 23:16:35 -0500 (EST)

branch: externals/metar
commit 8c6596d3acd52f4b120041c8afb3eaf22e89be78
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>

    * packages/metar/metar.el (metar-latitude-longitude-distance-haversine):
    `macrolet' is called `cl-macrolet' in cl-lib.
    (metar-station-countries): Avoid `add-to-list'.  Use dolist.
---
 metar.el | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/metar.el b/metar.el
index cbba5f8..43a72db 100644
--- a/metar.el
+++ b/metar.el
@@ -120,8 +120,8 @@ LATITUDE2/LONGITUDE2."
                                              latitude2 longitude2)
   "Caluclate the distance (in kilometers) between two points on the
 surface of the earth given as LATITUDE1, LONGITUDE1, LATITUDE2 and LONGITUDE2."
-  (macrolet ((distance (d1 d2)
-              `(expt (sin (/ (degrees-to-radians (- ,d2 ,d1)) 2)) 2)))
+  (cl-macrolet ((distance (d1 d2)
+                 `(expt (sin (/ (degrees-to-radians (- ,d2 ,d1)) 2)) 2)))
     (let ((a (+ (distance latitude1 latitude2)
                (* (cos (degrees-to-radians latitude1)) (cos 
(degrees-to-radians latitude2))
                   (distance longitude1 longitude2)))))
@@ -456,11 +456,10 @@ Otherwise, determine the best station via 
latitude/longitude."
        (message "No weather information found, sorry.")))))
   
 (defun metar-station-countries ()
-  (let (countries (stations (metar-stations)))
-    (while stations
-      (let ((country (cdr (assq 'country (car stations)))))
-       (add-to-list 'countries country))
-      (setq stations (cdr stations)))
+  (let (countries)
+    (dolist (station (metar-stations))
+      (let ((country (cdr (assq 'country station))))
+       (cl-pushnew country countries :test #'equal)))
     countries))
 
 (defun metar-stations-in-country (country)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]