emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/multishell aae3f1e 06/23: Use dolist instead of mapcar.


From: Stefan Monnier
Subject: [elpa] externals/multishell aae3f1e 06/23: Use dolist instead of mapcar.
Date: Sun, 29 Nov 2020 23:19:37 -0500 (EST)

branch: externals/multishell
commit aae3f1e2037796641c0f81e2b14141195e83b23e
Author: Ken Manheimer <ken.manheimer@gmail.com>
Commit: Ken Manheimer <ken.manheimer@gmail.com>

    Use dolist instead of mapcar.
    
    From gnu people's fixes.
---
 multishell-list.el | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/multishell-list.el b/multishell-list.el
index 125e8c0..38aad26 100644
--- a/multishell-list.el
+++ b/multishell-list.el
@@ -253,15 +253,14 @@ Initial sort is from most to least recently used:
 For duplicates, we prefer the ones that have paths."
   (let ((tally (make-hash-table :test #'equal))
         got name name-order-reversed already)
-    (mapcar #'(lambda (entry)
-                (setq name (multishell-name-from-entry entry)
-                      already (gethash name tally nil))
-                (when (not already)
-                  (push name name-order-reversed))
-                (when (or (not already) (< (length already) (length entry)))
-                  ;; Add new or replace shorter prior entry for name:
-                  (puthash name entry tally)))
-            entries)
+    (dolist (entry entries)
+      (setq name (multishell-name-from-entry entry)
+            already (gethash name tally nil))
+      (when (not already)
+        (push name name-order-reversed))
+      (when (or (not already) (< (length already) (length entry)))
+        ;; Add new or replace shorter prior entry for name:
+        (puthash name entry tally)))
     (dolist (name name-order-reversed)
       (push (gethash name tally) got))
     got))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]