emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/dash bf8a462 243/316: Partially revert last change


From: ELPA Syncer
Subject: [elpa] externals/dash bf8a462 243/316: Partially revert last change
Date: Mon, 15 Feb 2021 15:58:10 -0500 (EST)

branch: externals/dash
commit bf8a46273beb84915a7695b9735b550ac04b6d21
Author: Basil L. Contovounesios <contovob@tcd.ie>
Commit: Basil L. Contovounesios <contovob@tcd.ie>

    Partially revert last change
    
    There is no need to call eval on Emacs 26+, but tests fail in
    earlier versions without it, so bring it back, but this time with
    lexical-binding, at least.
    
    * dev/examples-to-tests.el (example-to-should): Bring back eval.
---
 dev/examples-to-tests.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dev/examples-to-tests.el b/dev/examples-to-tests.el
index efe22c0..a8f8ab2 100644
--- a/dev/examples-to-tests.el
+++ b/dev/examples-to-tests.el
@@ -29,7 +29,8 @@
         ((eq sym '~>)
          `(should (approx-equal ,actual ,expected)))
         ((eq sym '!!>)
-         `(should-error ,actual :type ',expected))
+         ;; FIXME: Tests fail on Emacs 24-25 without `eval' for some reason.
+         `(should-error (eval ',actual lexical-binding) :type ',expected))
         ((error "Invalid test case: %S" `(,actual ,sym ,expected)))))
 
 (defmacro defexamples (cmd &rest examples)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]