[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/ivy-hydra bd80852 251/395: Fix punctuation in some erro
From: |
Basil L. Contovounesios |
Subject: |
[elpa] externals/ivy-hydra bd80852 251/395: Fix punctuation in some error messages |
Date: |
Thu, 25 Feb 2021 08:32:13 -0500 (EST) |
branch: externals/ivy-hydra
commit bd80852bb6f96174d9945455bb8de1ccee8b0768
Author: Basil L. Contovounesios <contovob@tcd.ie>
Commit: Oleh Krehel <ohwoeowho@gmail.com>
Fix punctuation in some error messages
* counsel.el (counsel-git-change-worktree)
(counsel--find-return-list, counsel-evil-marks)
(counsel-evil-registers, counsel--kmacro-candidates):
* ivy.el (ivy-avy, ivy-add-prompt-count, ivy-reverse-i-search):
Improve wording of error messages: remove trailing punctuation as
per Emacs conventions and avoid hard-coding key bindings.
Fixes #2541
---
counsel.el | 11 ++++++-----
ivy.el | 7 +++----
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/counsel.el b/counsel.el
index 5b147ca..20a470f 100644
--- a/counsel.el
+++ b/counsel.el
@@ -1734,7 +1734,7 @@ TREE is the selected candidate."
(ivy-read "Select worktree: "
(or (cl-delete default-directory (counsel-git-worktree-list)
:key #'counsel-git-worktree-parse-root :test
#'string=)
- (error "No other worktrees!"))
+ (error "No other worktrees"))
:action (lambda (tree)
(counsel-git-change-worktree-action
(ivy-state-directory ivy-last) tree))
@@ -2799,7 +2799,8 @@ FZF-PROMPT, if non-nil, is passed as `ivy-read' prompt
argument."
(defun counsel--find-return-list (args)
(unless (listp args)
- (user-error "`counsel-file-jump-args' is a list now, please customize
accordingly."))
+ (user-error
+ "`counsel-file-jump-args' is a list now; please customize accordingly"))
(counsel--call
(cons find-program args)
(lambda ()
@@ -4119,7 +4120,7 @@ When ARG is non-nil, display all active evil registers."
(if candidates
(counsel-mark--ivy-read candidates 'counsel-evil-marks)
(message "no evil marks are active")))
- (user-error "Required feature `evil' not installed or not loaded.")))
+ (user-error "Required feature `evil' not installed or loaded")))
;;** `counsel-package'
(defvar package--initialized)
@@ -4523,7 +4524,7 @@ matching the register's value description against a
regexp in
:require-match t
:action #'counsel-evil-registers-action
:caller 'counsel-evil-registers)
- (user-error "Required feature `evil' not installed.")))
+ (user-error "Required feature `evil' not installed")))
(ivy-configure 'counsel-evil-registers
:height 5
@@ -5494,7 +5495,7 @@ This is a combination of `kmacro-ring' and, together in a
list, `last-kbd-macro'
(condition-case nil
(format-kbd-macro (if (listp kmacro) (car kmacro) kmacro) 1)
;; Recover from error from `edmacro-fix-menu-commands'.
- (error "Warning: Cannot display macros containing mouse
clicks.")))
+ (error "Warning: Cannot display macros containing mouse
clicks")))
kmacro))
(cons
(if (listp last-kbd-macro)
diff --git a/ivy.el b/ivy.el
index 006be02..3eb6b9a 100644
--- a/ivy.el
+++ b/ivy.el
@@ -1829,7 +1829,7 @@ This string is inserted into the minibuffer."
(error "Package avy isn't installed"))
((= (minibuffer-depth) 0)
(user-error
- "This command is intended to be called with \"C-'\" from
`ivy-read'."))
+ "This command is intended to be called from within `ivy-read'"))
(t
(let* ((avy-all-windows nil)
(avy-keys (or (cdr (assq 'ivy-avy avy-keys-alist))
@@ -2498,8 +2498,7 @@ This is useful for recursive `ivy-read'."
(defun ivy-add-prompt-count (prompt)
"Add count information to PROMPT."
(cond ((null ivy-count-format)
- (error
- "`ivy-count-format' can't be nil. Set it to \"\" instead"))
+ (error "`ivy-count-format' must not be nil; set it to \"\" instead"))
((string-match "%d.*\\(%d\\)" ivy-count-format)
(let* ((w
(if (listp ivy--all-candidates)
@@ -4873,7 +4872,7 @@ You can also delete an element from history with
\\[ivy-reverse-i-search-kill]."
(cond
((= (minibuffer-depth) 0)
(user-error
- "This command is intended to be called with \"C-r\" from `ivy-read'."))
+ "This command is intended to be called from within `ivy-read'"))
;; don't recur
((and (> (minibuffer-depth) 1)
(eq (ivy-state-caller ivy-last) 'ivy-reverse-i-search)))
- [elpa] externals/ivy-hydra ffa5a5f 258/395: counsel-describe-symbol: autoload, (continued)
- [elpa] externals/ivy-hydra ffa5a5f 258/395: counsel-describe-symbol: autoload, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 71f5727 261/395: counsel.el (counsel--git-grep-index): Don't error on null buffer-file-name, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 84efa3a 262/395: Ensure counsel--git-grep-index returns non-nil, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 6eda8fa 254/395: Fix recent ivy-auto-shrink-minibuffer-alist typo, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra b40af52 267/395: counsel.el (counsel-find-file-undo): Remap undo, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra fc3252b 274/395: Don't insert ^ on aborting completion in region, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra a4a22e0 294/395: ivy.el (ivy-display-style): Remove, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra ee747e6 290/395: ivy.el (ivy--update-history): Use ivy-state-current for file names, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra f67a2bb 215/395: ivy.el (ivy--filter): Prioritize :matcher, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra ca89b5d 236/395: ivy.el (ivy--recompute-index): Don't call ivy-set-index twice, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra bd80852 251/395: Fix punctuation in some error messages,
Basil L. Contovounesios <=
- [elpa] externals/ivy-hydra 8383dd6 248/395: * counsel.el: Unquote lambda actions, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 6916cbd 256/395: doc/ivy.org: Document ivy-insert-current-full, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra ace2475 260/395: counsel.el (counsel--sync-sentinel-on-exit): Fix regression, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra f1472ef 266/395: ivy.el: When completing files, make "RET" reverse "DEL", Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 82cb9da 272/395: ivy.el (ivy--do-shrink-window): Account for the extra prompt height, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 6f50fca 286/395: ivy.el: When reading file names, take the non-directory part of :initial-input, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra d452878 291/395: counsel-grep/ag/rg/pt/...: Allow to deplay subprocess creation, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 84dfbf8 296/395: ivy-avy.el: Checkdoc, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 864570a 323/395: ivy.el (ivy--get-multi-action): Fix and add a test, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 05c12fc 310/395: counsel.el (counsel--grep-smart-case-flag): Check if base command is a string, Basil L. Contovounesios, 2021/02/25