[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/ivy-hydra fc2801f 367/395: `counsel-find-file': open fi
From: |
Basil L. Contovounesios |
Subject: |
[elpa] externals/ivy-hydra fc2801f 367/395: `counsel-find-file': open file in foreground |
Date: |
Thu, 25 Feb 2021 08:32:40 -0500 (EST) |
branch: externals/ivy-hydra
commit fc2801f02d1c21e530167f822112caf7d2e98c85
Author: Nikita Bloshchanevich <nikblos@outlook.com>
Commit: Basil L. Contovounesios <contovob@tcd.ie>
`counsel-find-file': open file in foreground
`counsel-find-file-action' calls `find-file' wrapped in
`with-ivy-window', which causes the file to be opened in the `ivy'
window, which is destroyed afterwards. This causes the file to be
opened in the background. Unwrap the body from `with-ivy-window',
since that isn't needed, fixing the bug.
Copyright-paperwork-exempt: yes
Closes #2752.
---
counsel.el | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/counsel.el b/counsel.el
index 0e6a26f..51c283e 100644
--- a/counsel.el
+++ b/counsel.el
@@ -1986,15 +1986,14 @@ Skip some dotfiles unless `ivy-text' requires them."
(defun counsel-find-file-action (x)
"Find file X."
- (with-ivy-window
- (cond ((and counsel-find-file-speedup-remote
- (file-remote-p ivy--directory))
- (let ((find-file-hook nil))
- (find-file (expand-file-name x ivy--directory))))
- ((member (file-name-extension x) counsel-find-file-extern-extensions)
- (counsel-find-file-extern x))
- (t
- (find-file (expand-file-name x ivy--directory))))))
+ (cond ((and counsel-find-file-speedup-remote
+ (file-remote-p ivy--directory))
+ (let ((find-file-hook nil))
+ (find-file (expand-file-name x ivy--directory))))
+ ((member (file-name-extension x) counsel-find-file-extern-extensions)
+ (counsel-find-file-extern x))
+ (t
+ (find-file (expand-file-name x ivy--directory)))))
(defun counsel--preselect-file ()
"Return candidate to preselect during filename completion.
- [elpa] externals/ivy-hydra d4fd99f 316/395: Respect original default choice when deduplicating extra actions, (continued)
- [elpa] externals/ivy-hydra d4fd99f 316/395: Respect original default choice when deduplicating extra actions, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 62815d9 311/395: Makefile: Compile ivy-avy.el, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 7c0796f 333/395: ivy.el (ivy-shrink-after-dispatching): Resize only when in minibuffer, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra a007ba6 334/395: Fix for counsel-grep-like-occur, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra eb53165 313/395: ivy.el (ivy--compute-extra-actions): Dedup on key, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 5d52d4b 352/395: Call isearch-filter-predicate instead of isearch-range-invisible, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 7f88b67 345/395: counsel.el (counsel-highlight-with-face): New action for counsel-faces, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra d52ee0a 301/395: ivy.el (ivy-completion-in-region): Restrict new behavior to elisp code, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 3b1737c 361/395: * counsel.el (counsel-linux-app): Improve prompt., Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 1723799 368/395: Fix M-o 'Wrong type argument: characterp' error, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra fc2801f 367/395: `counsel-find-file': open file in foreground,
Basil L. Contovounesios <=
- [elpa] externals/ivy-hydra ae9b121 366/395: Avoid face blending errors when loading swiper.el, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 796220b 357/395: ivy.el (ivy-alt-done): Extend to programmed completion, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 911a360 365/395: Consistently use modern face spec syntax, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 74f411d 355/395: Remove Emacs 28 workaround in counsel-descbinds, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 778d8bf 363/395: * counsel.el (counsel-org-files): Simplify regexp., Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra ab36ccb 364/395: * counsel.el (counsel-org-files): Fix regexp., Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra b65e401 351/395: counsel.el (counsel-file-jump-from-find): Add and bind to "`", Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra c6b60d3 337/395: counsel.el (counsel-ag): Prompt for args on a double universal-argument, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra d18ec97 338/395: counsel.el (compile-command): better handle our metadata, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra d321048 358/395: ivy.el (ivy-add-prompt-count): Simplify, Basil L. Contovounesios, 2021/02/25