[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/emms b7684ba 39/80: Match id3v1 genres in id3v2.4 frame
From: |
Stefan Monnier |
Subject: |
[elpa] externals/emms b7684ba 39/80: Match id3v1 genres in id3v2.4 frame |
Date: |
Wed, 17 Mar 2021 18:42:26 -0400 (EDT) |
branch: externals/emms
commit b7684baef60f08a04e4e598ee21a5ea55ef23bd5
Author: Petteri Hintsanen <phintsan@julia.lan>
Commit: Petteri Hintsanen <phintsan@julia.lan>
Match id3v1 genres in id3v2.4 frame
v2.4 does not enclose genre references in parentheses.
---
emms-info-native.el | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/emms-info-native.el b/emms-info-native.el
index e3181ef..405bf25 100644
--- a/emms-info-native.el
+++ b/emms-info-native.el
@@ -878,10 +878,11 @@ with key/value-pair. Extract the key and, if it is a
mapped
element in `emms-info-native--id3v2-frame-to-info', use it as
INFO-ID.
-If INFO-ID is `genre', assume that DATA is either id3v1 genre
-reference \"(XX)\" or plain genre string. In the former case,
-map XX to a string via `emms-info-native--id3v1-genres'; in the
-latter case use the genre string verbatim.
+If INFO-ID is `genre', assume that DATA is either an integral
+id3v1 genre reference or a plain genre string. In the former
+case map the reference to a string via
+`emms-info-native--id3v1-genres'; in the latter case use the
+genre string verbatim.
Return a cons cell (INFO-ID . VALUE) where VALUE is the decoded
string."
@@ -889,7 +890,7 @@ string."
(let ((str (emms-info-native--decode-id3v2-string data)))
(cond ((stringp info-id) (cons info-id str))
((eq info-id 'genre)
- (if (string-match "^(\\([0-9]+\\))" str)
+ (if (string-match "^(?\\([0-9]+\\))?" str)
(let ((v1-genre (assoc (string-to-number (match-string 1 str))
emms-info-native--id3v1-genres)))
(when v1-genre (cons "genre" (cdr v1-genre))))
- [elpa] externals/emms 6e5d477 21/80: Simplify FLAC code, (continued)
- [elpa] externals/emms 6e5d477 21/80: Simplify FLAC code, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 757043b 41/80: Merge branch 'info-native', Stefan Monnier, 2021/03/17
- [elpa] externals/emms 7479d7d 19/80: Use lexical binding, Stefan Monnier, 2021/03/17
- [elpa] externals/emms a372976 20/80: Fix Opus channel mapping decoding, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 4a4a358 23/80: Remove emms-info-native return value, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 0fe6100 28/80: Improve id3v2 error handling, Stefan Monnier, 2021/03/17
- [elpa] externals/emms cd437ca 40/80: Fix byte compilation, Stefan Monnier, 2021/03/17
- [elpa] externals/emms a57cc7e 43/80: * emms-bookmarks.el: lexical scoping declaration, Stefan Monnier, 2021/03/17
- [elpa] externals/emms fcdb111 25/80: Add mappings for more id3v2 text frames, Stefan Monnier, 2021/03/17
- [elpa] externals/emms c8f198d 31/80: Put some id3v2.4 frame data to info-date instead of info-year, Stefan Monnier, 2021/03/17
- [elpa] externals/emms b7684ba 39/80: Match id3v1 genres in id3v2.4 frame,
Stefan Monnier <=
- [elpa] externals/emms d12014d 50/80: * emms-i18n.el: lexical declaration, Stefan Monnier, 2021/03/17
- [elpa] externals/emms abf6b01 49/80: * emms-history.el: lexical declaration, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 0fcea44 52/80: * emms-info.el: add lexical and remove unused lexical variable, Stefan Monnier, 2021/03/17
- [elpa] externals/emms ba16ff6 13/80: * emms-tag-editor.el: lexical compatibility work, Stefan Monnier, 2021/03/17
- [elpa] externals/emms bf22384 16/80: Clean up Vorbis code, Stefan Monnier, 2021/03/17
- [elpa] externals/emms a879267 37/80: Decode id3v2 user-defined text frames, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 5531af7 38/80: Add support for id3v1 genres, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 6a1c281 66/80: * emms-player-mplayer.el: lexical declaration, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 7ca6cd3 70/80: * emms-playlist-mode.el:, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 89ccb7d 75/80: Rewrite manual Chapter 13 Track Information, Stefan Monnier, 2021/03/17