emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/javaimp 1102deb: javaimp-maven.el (javaimp--maven-visit


From: Filipp Gunbin
Subject: [elpa] externals/javaimp 1102deb: javaimp-maven.el (javaimp--maven-visit): Improve comment
Date: Tue, 6 Apr 2021 09:09:45 -0400 (EDT)

branch: externals/javaimp
commit 1102deb2dd5f3a0d27d43b47db795d1af173e1da
Author: Filipp Gunbin <fgunbin@fastmail.fm>
Commit: Filipp Gunbin <fgunbin@fastmail.fm>

    javaimp-maven.el (javaimp--maven-visit): Improve comment
---
 javaimp-maven.el | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/javaimp-maven.el b/javaimp-maven.el
index 37fc173..eee886f 100644
--- a/javaimp-maven.el
+++ b/javaimp-maven.el
@@ -49,9 +49,16 @@ resulting module trees."
                             (javaimp--maven-module-from-xml proj-elt file))
                           projects)))
 
-    ;; Set files in a separate step.  "Real" parent of a child (given
-    ;; by <parent>) does not necessary contains the child in its
-    ;; <modules>.
+    ;; Set :file slots in a separate step because Maven doesn't seem
+    ;; to give pom.xml file location for each subproject.  We build
+    ;; tree below by using child->parent links (<parent> in child
+    ;; pom.xml), that also doesn't help to find pom.xml itself.
+    ;; Furthermore, the reverse link (<modules> in parent) may not
+    ;; correspond to a project's real children.  So we take this
+    ;; approach: starting from the top-level pom.xml, descend into
+    ;; children using <modules>.  For each child pom.xml, find its
+    ;; corresponding module by id in the whole module list, and set
+    ;; that module's :file.
     (javaimp--maven-fill-modules-files file modules)
     (when-let ((without-files
                 (seq-filter (lambda (m)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]