emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/corfu fef8377 02/16: Add popup comment (See #10 and #15


From: Protesilaos Stavrou
Subject: [elpa] externals/corfu fef8377 02/16: Add popup comment (See #10 and #15)
Date: Wed, 28 Apr 2021 14:20:02 -0400 (EDT)

branch: externals/corfu
commit fef837718bc138b2ad6844f588a6e51eefae5726
Author: Daniel Mendler <mail@daniel-mendler.de>
Commit: Daniel Mendler <mail@daniel-mendler.de>

    Add popup comment (See #10 and #15)
---
 corfu.el | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/corfu.el b/corfu.el
index 1a96dd8..164bd7b 100644
--- a/corfu.el
+++ b/corfu.el
@@ -185,6 +185,15 @@ If `line-spacing/=nil' or in text-mode, the background 
color is used instead.")
              :background ,(face-attribute bg :background)
              :foreground ,(face-attribute fg :foreground)))))
 
+;; XXX The popup code is unreliable. There are many problematic
+;; scenarios where the popup may fail:
+;; 1. display-line-numbers-mode
+;; 2. Overhanging lines (popup at the end of buffer)
+;; 3. Overhanging columns (popup at the end of line)
+;; 4. Outline folding
+;; 5. Wide characters like TAB
+;; 6. Lines with invisible/display properties (Org folding)
+;; 7. Scrolled windows
 (defun corfu--popup (pos lines &optional curr lo bar)
   "Show LINES as popup at POS, with CURR highlighted and scrollbar from LO to 
LO+BAR."
   (save-excursion



reply via email to

[Prev in Thread] Current Thread [Next in Thread]