[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/isearch-mb 5d5b0e9 17/20: Replace advices by let-bindin
From: |
Stefan Monnier |
Subject: |
[elpa] externals/isearch-mb 5d5b0e9 17/20: Replace advices by let-bindings where possible |
Date: |
Sun, 16 May 2021 17:21:15 -0400 (EDT) |
branch: externals/isearch-mb
commit 5d5b0e9ee7bbccd82bbdcee7dc0c9063f8bf81c9
Author: Augusto Stoffel <arstoffel@gmail.com>
Commit: Augusto Stoffel <arstoffel@gmail.com>
Replace advices by let-bindings where possible
---
isearch-mb.el | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/isearch-mb.el b/isearch-mb.el
index 1dcb3d4..6d5e441 100644
--- a/isearch-mb.el
+++ b/isearch-mb.el
@@ -174,6 +174,8 @@ minibuffer."
(apply
(catch 'isearch-mb--continue
(cl-letf (((cdr isearch-mode-map) nil)
+ ((symbol-function #'isearch-pre-command-hook) #'ignore)
+ ((symbol-function #'isearch--momentary-message)
#'isearch-mb--momentary-message)
;; We need to set `inhibit-redisplay' at certain points to
;; avoid flicker. As a side effect, window-start/end in
;; `isearch-lazy-highlight-update' will have incorrect
values,
@@ -194,8 +196,6 @@ minibuffer."
(advice-add fun :around #'isearch-mb--with-buffer))
(dolist (fun isearch-mb--after-exit)
(advice-add fun :around #'isearch-mb--after-exit))
- (advice-add #'isearch--momentary-message :override
#'isearch-mb--momentary-message)
- (advice-add #'isearch-pre-command-hook :override #'ignore)
(read-from-minibuffer
"I-search: "
nil
@@ -211,9 +211,7 @@ minibuffer."
(dolist (fun isearch-mb--after-exit)
(advice-remove fun #'isearch-mb--after-exit))
(dolist (fun isearch-mb--with-buffer)
- (advice-remove fun #'isearch-mb--with-buffer))
- (advice-remove #'isearch--momentary-message
#'isearch-mb--momentary-message)
- (advice-remove #'isearch-pre-command-hook #'ignore)))
+ (advice-remove fun #'isearch-mb--with-buffer))))
(if isearch-mode '(isearch-done) '(ignore)))))
(quit (if isearch-mode (isearch-cancel) (signal 'quit nil)))))
- [elpa] branch externals/isearch-mb created (now c270809), Stefan Monnier, 2021/05/16
- [elpa] externals/isearch-mb 1c16403 15/20: Keep advices only for the duration of a search session, Stefan Monnier, 2021/05/16
- [elpa] externals/isearch-mb ce41e00 12/20: Add a Readme, Stefan Monnier, 2021/05/16
- [elpa] externals/isearch-mb c6fc566 18/20: Use remapping in minibuffer keymap, Stefan Monnier, 2021/05/16
- [elpa] externals/isearch-mb 5d5b0e9 17/20: Replace advices by let-bindings where possible,
Stefan Monnier <=
- [elpa] externals/isearch-mb a663c22 16/20: Better place to check if Isearch is still active, Stefan Monnier, 2021/05/16
- [elpa] externals/isearch-mb dc603a9 03/20: Lazily highlight the whole buffer, to avoid missing overlays, Stefan Monnier, 2021/05/16
- [elpa] externals/isearch-mb 40add97 01/20: Initial commit, Stefan Monnier, 2021/05/16
- [elpa] externals/isearch-mb 8566108 02/20: Many changes, Stefan Monnier, 2021/05/16
- [elpa] externals/isearch-mb 223b1b9 04/20: Introduce a buffer-local minor mode, Stefan Monnier, 2021/05/16
- [elpa] externals/isearch-mb 5805f13 07/20: Add keybinding for newline, Stefan Monnier, 2021/05/16
- [elpa] externals/isearch-mb d075efe 06/20: Rename minor modes, move a test to the timer function, Stefan Monnier, 2021/05/16
- [elpa] externals/isearch-mb 9f11fda 05/20: Several improvements, reorganization, Stefan Monnier, 2021/05/16
- [elpa] externals/isearch-mb a8d2a15 10/20: Provide future history, Stefan Monnier, 2021/05/16
- [elpa] externals/isearch-mb fccf1b7 08/20: Fix post-command hook for the failed search case, Stefan Monnier, 2021/05/16