[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/marginalia 2b85b73 130/241: fix marginalia--full-candid
From: |
Stefan Monnier |
Subject: |
[elpa] externals/marginalia 2b85b73 130/241: fix marginalia--full-candidate |
Date: |
Fri, 28 May 2021 20:49:12 -0400 (EDT) |
branch: externals/marginalia
commit 2b85b73bca6e1610b86b0de8c2c4c414a9e99185
Author: Daniel Mendler <mail@daniel-mendler.de>
Commit: Daniel Mendler <mail@daniel-mendler.de>
fix marginalia--full-candidate
cc @oantolin
It is a bit ugly that we are now switching back and forth,
but running the annotators in the context of the original
window makes more sense for most annotators. It seems to be
less error-prone this way.
---
marginalia.el | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/marginalia.el b/marginalia.el
index 714ffca..56627e4 100644
--- a/marginalia.el
+++ b/marginalia.el
@@ -554,18 +554,19 @@ component of a full file path.
This function returns what would be the minibuffer contents after
using `minibuffer-force-complete' on the candidate CAND."
- (if (minibufferp)
- (let* ((contents (minibuffer-contents))
- (pt (- (point) (minibuffer-prompt-end)))
- (bounds (completion-boundaries
- (substring contents 0 pt)
- minibuffer-completion-table
- minibuffer-completion-predicate
- (substring contents pt))))
- (concat (substring contents 0 (car bounds))
- cand
- (substring contents (+ pt (cdr bounds)))))
- ;; not in a minibuffer, trust that cand already conveys all
+ (if-let (win (active-minibuffer-window))
+ (with-selected-window win
+ (let* ((contents (minibuffer-contents))
+ (pt (- (point) (minibuffer-prompt-end)))
+ (bounds (completion-boundaries
+ (substring contents 0 pt)
+ minibuffer-completion-table
+ minibuffer-completion-predicate
+ (substring contents pt))))
+ (concat (substring contents 0 (car bounds))
+ cand
+ (substring contents (+ pt (cdr bounds))))))
+ ;; no minibuffer is active, trust that cand already conveys all
;; necessary information (there's not much else we can do)
cand))
- [elpa] externals/marginalia 333ff80 104/241: fix #32, (continued)
- [elpa] externals/marginalia 333ff80 104/241: fix #32, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 531fb6e 107/241: fix #27, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia ef4fabf 106/241: add preliminary support for affixation-function, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 69332ba 110/241: fix hex code formatting, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia d0c4e41 111/241: marginalia--field: fix nil handling, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 7d9c6aa 117/241: binding hash: specify larger initial size, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia b69be18 119/241: marginalia-annotate-variable: add local indicator, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 5802a5d 118/241: readme: configuration example for selectrum refresh after marginalia-cycle, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia cf9f411 125/241: marginalia: always run annotators in the original window context, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia c574a26 054/241: more colors!, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 2b85b73 130/241: fix marginalia--full-candidate,
Stefan Monnier <=
- [elpa] externals/marginalia 3ec73cd 138/241: Merry Christmas, MELPA!, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 5129917 150/241: fix readme, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 2f849d8 013/241: Simplify marginalia--completion-metadata-get, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia c97911b 021/241: All classifiers from Embark have been imported, remove TODO, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 0cb98a0 023/241: Remove default value from prompt before matching, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 7fe8f71 027/241: improve buffer annotation formatting, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 4ba9804 031/241: Fix bug: file annotations were only shown for current directory, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 78023eb 038/241: update readme, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia b6d2e22 037/241: fix typo, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 472b47a 041/241: add comment to marginalia-toggle-annotators, Stefan Monnier, 2021/05/28