emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/marginalia 3210152 033/241: add comment to marginalia--


From: Stefan Monnier
Subject: [elpa] externals/marginalia 3210152 033/241: add comment to marginalia--full-candidate
Date: Fri, 28 May 2021 20:48:51 -0400 (EDT)

branch: externals/marginalia
commit 321015258db8524f376b448b2324e16d411733f2
Author: Daniel Mendler <mail@daniel-mendler.de>
Commit: Daniel Mendler <mail@daniel-mendler.de>

    add comment to marginalia--full-candidate
---
 marginalia.el | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/marginalia.el b/marginalia.el
index 9081339..20ef300 100644
--- a/marginalia.el
+++ b/marginalia.el
@@ -262,6 +262,11 @@ determine it."
         "")
       marginalia-file-name-width))))
 
+;; At some point we might want to revisit how this function is implemented. 
Maybe we come up with a
+;; more direct way to implement it. While Emacs does not use the notion of 
"full candidate", there
+;; is a function `completion-boundaries' to compute them, and in (info 
"(elisp)Programmed
+;; Completion") it is documented how a completion table should respond to 
boundaries requests.
+;; See the discussion at 
https://github.com/minad/marginalia/commit/4ba98045dd33bcf1396a888dbbae2dc801dce7c5
 (defun marginalia--full-candidate (cand)
   "Return completion candidate CAND in full.
 For some completion tables, the completion candidates offered are



reply via email to

[Prev in Thread] Current Thread [Next in Thread]