[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/which-key f6ce67d 05/10: Get which-key--buffer's window
From: |
Stefan Monnier |
Subject: |
[elpa] externals/which-key f6ce67d 05/10: Get which-key--buffer's window from any frame |
Date: |
Wed, 2 Jun 2021 18:29:40 -0400 (EDT) |
branch: externals/which-key
commit f6ce67d7053d00e11e0eda653e2f39d7955fb3b4
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>
Get which-key--buffer's window from any frame
Previously we assumed the buffer was being displayed in a window
of the current frame, which isn't the case if e.g. a child frame
is being used.
We also cannot assume that the third-party code that sets up such
a child frame also deletes it. `which-key-posframe' for example
merely hides it.
---
which-key.el | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/which-key.el b/which-key.el
index 3f5f809..74accfa 100644
--- a/which-key.el
+++ b/which-key.el
@@ -1175,7 +1175,10 @@ popup)."
(defun which-key--popup-showing-p ()
(and (bufferp which-key--buffer)
- (window-live-p (get-buffer-window which-key--buffer))))
+ (or (window-live-p (get-buffer-window which-key--buffer))
+ (let ((window (get-buffer-window which-key--buffer t)))
+ (and (window-live-p window)
+ (frame-visible-p (window-frame window)))))))
(defun which-key--show-popup (act-popup-dim)
"Show the which-key buffer.
- [elpa] externals/which-key updated (5fb3030 -> fc29864), Stefan Monnier, 2021/06/02
- [elpa] externals/which-key 7927209 01/10: fix which-key--show-keymap for which-key-enable-extended-define-key, Stefan Monnier, 2021/06/02
- [elpa] externals/which-key f6ce67d 05/10: Get which-key--buffer's window from any frame,
Stefan Monnier <=
- [elpa] externals/which-key fc29864 10/10: Fix whitespace, Stefan Monnier, 2021/06/02
- [elpa] externals/which-key aa91a7c 02/10: Fix nesting-level of "God-mode" section, Stefan Monnier, 2021/06/02
- [elpa] externals/which-key 016b9bb 04/10: Cosmetics, Stefan Monnier, 2021/06/02
- [elpa] externals/which-key fa1b4c9 06/10: Merge pull request #303 from tarsiiformes/posframe, Stefan Monnier, 2021/06/02
- [elpa] externals/which-key 1f5e532 03/10: Avoid code-duplication in which-key--hide-popup, Stefan Monnier, 2021/06/02
- [elpa] externals/which-key ef1fc43 07/10: Reference issues #93 and #175 in README, Stefan Monnier, 2021/06/02
- [elpa] externals/which-key 81d9395 08/10: Fix README links, Stefan Monnier, 2021/06/02
- [elpa] externals/which-key 7e854d0 09/10: Fix recent commit, Stefan Monnier, 2021/06/02