[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/go-mode 775c77a 241/495: immediately store match data in g
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/go-mode 775c77a 241/495: immediately store match data in go-unused-imports-lines |
Date: |
Sat, 7 Aug 2021 09:05:23 -0400 (EDT) |
branch: elpa/go-mode
commit 775c77a1b32e6012c55c59a8195483aff9f5bed4
Author: Iwasaki Yudai <yudai.iwasaki@ntti3.com>
Commit: Dominik Honnef <dominik@honnef.co>
immediately store match data in go-unused-imports-lines
Calling other functions, such as file-truename in our case, can
overwrite the match data.
---
go-mode.el | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/go-mode.el b/go-mode.el
index fca4937..132a4cd 100644
--- a/go-mode.el
+++ b/go-mode.el
@@ -1311,9 +1311,11 @@ If IGNORE-CASE is non-nil, the comparison is
case-insensitive."
(reverse (remove nil
(mapcar
(lambda (line)
- (if (string-match "^\\(.+\\):\\([[:digit:]]+\\):
imported and not used: \".+\".*$" line)
- (if (string= (file-truename (match-string 1 line))
(file-truename buffer-file-name))
- (string-to-number (match-string 2 line)))))
+ (when (string-match "^\\(.+\\):\\([[:digit:]]+\\):
imported and not used: \".+\".*$" line)
+ (let ((error-file-name (match-string 1 line))
+ (error-line-num (match-string 2 line)))
+ (if (string= (file-truename error-file-name)
(file-truename buffer-file-name))
+ (string-to-number error-line-num)))))
(split-string (shell-command-to-string
(concat go-command
(if (string-match "_test\.go$"
buffer-file-truename)
- [nongnu] elpa/go-mode c9f5e92 483/495: Fix indentation of chained dangling selectors., (continued)
- [nongnu] elpa/go-mode c9f5e92 483/495: Fix indentation of chained dangling selectors., ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode fdf46fe 492/495: Fix go.mod fontification., ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode e8eea7f 487/495: Fix fontification of multiline type switch clauses., ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode 2f2910c 223/495: fix end-of-defun for function with inline struct/interface arguments, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode f1adac0 230/495: switch versioning to semver, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode d9f0bee 232/495: add variable to customize godef command, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode 3da268f 285/495: README: improve description of new functions, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode 9047fcd 238/495: add a menu, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode 466e188 239/495: add `go-play-browse-function', ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode 8c13a82 240/495: match identifiers, not type names, when highlighting struct literal, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode 775c77a 241/495: immediately store match data in go-unused-imports-lines,
ELPA Syncer <=
- [nongnu] elpa/go-mode aaea941 242/495: bump version to 1.2.0, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode bf4a097 243/495: add Iwasaki Yudai to AUTHORS, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode 498452d 244/495: Don't set old buffer as active after godef--find-file-line-column, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode 7041a20 245/495: Bump version to 1.2.1, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode bbaba91 246/495: Add godoc-mode, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode 26493e3 264/495: Fix bug in go-goto-function if point is on a non-docstring, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode fa29aea 265/495: go-goto-method-receiver: handle anonymous functions, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode 3d801ed 268/495: Ignore anonymous functions if called with prefix, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode c0a3a16 269/495: Update README.md to reflect the latest version of the truth, ELPA Syncer, 2021/08/07
- [nongnu] elpa/go-mode c849d72 273/495: Don't throw errors in some go-goto-* functions, ELPA Syncer, 2021/08/07