emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/go-mode b65e408 334/495: go.tools/cmd/oracle: cosmetic twe


From: ELPA Syncer
Subject: [nongnu] elpa/go-mode b65e408 334/495: go.tools/cmd/oracle: cosmetic tweaks to Emacs.
Date: Sat, 7 Aug 2021 09:05:42 -0400 (EDT)

branch: elpa/go-mode
commit b65e4083feea76159f6db90cf5a2d3244dadab50
Author: Alan Donovan <adonovan@google.com>
Commit: Dominik Honnef <dominik@honnef.co>

    go.tools/cmd/oracle: cosmetic tweaks to Emacs.
    
    1. call display-buffer after the postprocessing step to avoid display 
glitch.
    2. suppress the postprocessing progress message---it's too verbose.
       (instead I should just make the postprocessing loop faster)
    
    Also: rename channel-peers to just peers for consistency with other 
commands and documentation.
    
    R=dominik.honnef
    CC=golang-dev
    https://golang.org/cl/13388044
---
 guru_import/cmd/oracle/oracle.el | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/guru_import/cmd/oracle/oracle.el b/guru_import/cmd/oracle/oracle.el
index 50e5830..c3718c4 100644
--- a/guru_import/cmd/oracle/oracle.el
+++ b/guru_import/cmd/oracle/oracle.el
@@ -106,10 +106,6 @@ result."
       (insert "\n")
       (compilation-mode)
       (setq compilation-error-screen-columns nil)
-      (let ((w (display-buffer (current-buffer))))
-        (balance-windows)
-        (shrink-window-if-larger-than-buffer w)
-        (set-window-point w (point-min)))
 
       ;; Hide the file/line info to save space.
       ;; Replace each with a little widget.
@@ -121,7 +117,7 @@ result."
         (while (not (null p))
           (let ((np (compilation-next-single-property-change p 
'compilation-message)))
             ;; TODO(adonovan): this can be verbose in the *Messages* buffer.
-            (message "Post-processing link (%d%%)" (/ (* p 100) (point-max)))
+            ;; (message "Post-processing link (%d%%)" (/ (* p 100) 
(point-max)))
             (if np
                 (when (equal (line-number-at-pos p) (line-number-at-pos np))
                   ;; np is (typically) the space following ":"; consume it too.
@@ -129,7 +125,12 @@ result."
                   (goto-char np)
                   (insert " ")))
             (setq p np)))
-        (message nil)))))
+        (message nil))
+
+      (let ((w (display-buffer (current-buffer))))
+        (balance-windows)
+        (shrink-window-if-larger-than-buffer w)
+        (set-window-point w (point-min))))))
 
 (defun go-oracle-callees ()
   "Show possible callees of the function call at the current point."
@@ -168,7 +169,7 @@ containing the current point."
   (interactive)
   (go-oracle--run "freevars"))
 
-(defun go-oracle-channel-peers ()
+(defun go-oracle-peers ()
   "Enumerate the set of possible corresponding sends/receives for
 this channel receive/send operation."
   (interactive)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]