emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/multiple-cursors fca0685 055/434: Use symbol properties on


From: ELPA Syncer
Subject: [nongnu] elpa/multiple-cursors fca0685 055/434: Use symbol properties on commands instead of maintaining a list of unsupported commands.
Date: Sat, 7 Aug 2021 09:19:54 -0400 (EDT)

branch: elpa/multiple-cursors
commit fca06858e946bbe8a6299c24cc014edaa2334382
Author: Magnar Sveen <magnars@gmail.com>
Commit: Magnar Sveen <magnars@gmail.com>

    Use symbol properties on commands instead of maintaining a list of 
unsupported commands.
---
 multiple-cursors-core.el | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/multiple-cursors-core.el b/multiple-cursors-core.el
index b293947..1e675e9 100644
--- a/multiple-cursors-core.el
+++ b/multiple-cursors-core.el
@@ -132,10 +132,10 @@ is executed normally for point, but skipped for the fake
 cursors."
   (let ((original-command (or (command-remapping this-original-command)
                               this-original-command)))
-    (if (memq original-command mc--unsupported-cmds)
+    (if (get original-command 'mc--unsupported)
         (message "%S is not supported with multiple cursors%s"
                  original-command
-                 (get original-command 'mc--unsupported-msg))
+                 (get original-command 'mc--unsupported))
       (if (not (memq original-command mc--cmds))
           (when (not (memq original-command mc--cmds-run-once))
             (message "Skipping %S" original-command))
@@ -173,16 +173,11 @@ multiple cursors editing.")
     (remove-hook 'post-command-hook 'mc/execute-this-command-for-all-cursors t)
     (mc/remove-fake-cursors)))
 
-(defvar mc--unsupported-cmds '()
-  "List of commands that does not work well with multiple cursors.
-Set up with the unsupported-cmd macro.")
-
 (defmacro unsupported-cmd (cmd msg)
   "Adds command to list of unsupported commands and prevents it
 from being executed if in multiple-cursors-mode."
   `(progn
-     (push (quote ,cmd) mc--unsupported-cmds)
-     (put (quote ,cmd) 'mc--unsupported-msg ,msg)
+     (put (quote ,cmd) 'mc--unsupported ,msg)
      (defadvice ,cmd (around unsupported-advice activate)
        "command isn't supported with multiple cursors"
        (unless (and multiple-cursors-mode (called-interactively-p 'any))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]