emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/gnuplot 07a8027 183/184: Do not add lines to kill-ring whe


From: ELPA Syncer
Subject: [nongnu] elpa/gnuplot 07a8027 183/184: Do not add lines to kill-ring when trimming the gnuplot buffer (#72)
Date: Sun, 29 Aug 2021 11:03:41 -0400 (EDT)

branch: elpa/gnuplot
commit 07a80272b86c081b40602ec0b080571f3269749d
Author: Maxime Tréca <16440823+mtreca@users.noreply.github.com>
Commit: GitHub <noreply@github.com>

    Do not add lines to kill-ring when trimming the gnuplot buffer (#72)
    
    I noticed that when the number of lines in the gnuplot comint buffer
    exceeds the maximum amount of lines, the extra lines are killed using
    kill-line, which causes the kill-ring to be polluted with those lines.
    This commit replaces kill-ring by delete-region, which does not have
    this side effect. The while loop also has been replaced by dotimes for
    clarity.
---
 gnuplot.el | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/gnuplot.el b/gnuplot.el
index 5345b26..b74a91b 100644
--- a/gnuplot.el
+++ b/gnuplot.el
@@ -1357,13 +1357,12 @@ This keeps that buffer from growing excessively in 
size.  Normally,
 this function is attached to `gnuplot-after-plot-hook'"
   (if (> gnuplot-buffer-max-size 0)
       (with-current-buffer gnuplot-buffer
-        (let ((nlines (count-lines (point-min) (point-max)))
-              (kill-whole-line t))
-          (while (> nlines gnuplot-buffer-max-size)
+        (let (gnuplot-lines (count-lines (point-min) (point-max)))
+          (dotimes (tmp (- gnuplot-lines gnuplot-buffer-max-size))
             (goto-char (point-min))
-            (kill-line)
-            (setq nlines (1- nlines)))
+            (delete-region (line-beginning-position) (1+ (line-end-position))))
           (goto-char (point-max))))))
+
 (add-hook 'gnuplot-after-plot-hook 'gnuplot-trim-gnuplot-buffer nil nil)
 
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]