[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/nginx-mode 47aaf2c 29/34: Remove `run-hook`, it is run aut
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/nginx-mode 47aaf2c 29/34: Remove `run-hook`, it is run automatically. |
Date: |
Sun, 29 Aug 2021 11:24:17 -0400 (EDT) |
branch: elpa/nginx-mode
commit 47aaf2c9a0beb0a530430b9c12ec148af6a2bd88
Author: Matus Goljer <dota.keys@gmail.com>
Commit: GitHub <noreply@github.com>
Remove `run-hook`, it is run automatically.
Hi.
When using `define-derived-mode` one doesn't need (and shouldn't) use
`run-hook` because the macro adds the form `run-mode-hook` itself when expanded
(use macroexpand to check!).
This results in the hook being called twice, see
```elisp
(defun my-nginx-mode-init ()
(message "Hello"))
(add-hook 'nginx-mode-hook 'my-nginx-mode-init)
```
In messages I have
Hello [2 times]
Simply removing the form and using the one provided by the macro is enough
to fix this.
---
nginx-mode.el | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/nginx-mode.el b/nginx-mode.el
index 9cf79e2..b038532 100644
--- a/nginx-mode.el
+++ b/nginx-mode.el
@@ -184,8 +184,7 @@ The variable nginx-indent-level controls the amount of
indentation.
(set (make-local-variable 'paragraph-separate) "\\([ \f]*\\|#\\)$")
(set (make-local-variable 'font-lock-defaults)
- '(nginx-font-lock-keywords nil))
- (run-hooks 'nginx-mode-hook))
+ '(nginx-font-lock-keywords nil)))
;;;###autoload
(add-to-list 'auto-mode-alist '("nginx\\.conf\\'" . nginx-mode))
- [nongnu] elpa/nginx-mode f33abe7 26/34: Use syntax table instead of font-lock regexp, (continued)
- [nongnu] elpa/nginx-mode f33abe7 26/34: Use syntax table instead of font-lock regexp, ELPA Syncer, 2021/08/29
- [nongnu] elpa/nginx-mode c13fa62 27/34: Merge pull request #15 from zonuexe/feature/comment-syntax-table, ELPA Syncer, 2021/08/29
- [nongnu] elpa/nginx-mode 95cb916 32/34: Add top-level Nginx configuration blocks to magic-fallback-mode-alist., ELPA Syncer, 2021/08/29
- [nongnu] elpa/nginx-mode 304c9e2 24/34: one more ref to font-lock-operator-face., ELPA Syncer, 2021/08/29
- [nongnu] elpa/nginx-mode bb5d84b 21/34: removed sites-enabled from default (has issues with apache-mode autoloads), ELPA Syncer, 2021/08/29
- [nongnu] elpa/nginx-mode 99d5eea 02/34: mention where you can find it, ELPA Syncer, 2021/08/29
- [nongnu] elpa/nginx-mode 0600403 03/34: syntax highlighting improvements, of a sort., ELPA Syncer, 2021/08/29
- [nongnu] elpa/nginx-mode 06fe730 10/34: add some auto-mode-alist magic. Fixes #6., ELPA Syncer, 2021/08/29
- [nongnu] elpa/nginx-mode 82098c5 19/34: auto-mode-alist now works :-), ELPA Syncer, 2021/08/29
- [nongnu] elpa/nginx-mode 8a296e3 22/34: Merge pull request #11 from chillum/master, ELPA Syncer, 2021/08/29
- [nongnu] elpa/nginx-mode 47aaf2c 29/34: Remove `run-hook`, it is run automatically.,
ELPA Syncer <=
- [nongnu] elpa/nginx-mode c37ae5f 30/34: Merge pull request #16 from Fuco1/patch-1, ELPA Syncer, 2021/08/29
- [nongnu] elpa/nginx-mode 9fc6ef2 01/34: initial checkin of working code, ELPA Syncer, 2021/08/29
- [nongnu] elpa/nginx-mode 79e1c5b 04/34: hrm. maybe highlighting parens and curly braces wasn't such a good idea (my eyes!), ELPA Syncer, 2021/08/29
- [nongnu] elpa/nginx-mode 88da7a7 12/34: Set auto-mode-alist at top-level and Add autoload cookie, ELPA Syncer, 2021/08/29
- [nongnu] elpa/nginx-mode a3ea629 33/34: Merge pull request #17 from joewreschnig/magic-fallback-mode, ELPA Syncer, 2021/08/29