emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/corfu 92f4d37: Fix position computation, remove hack (F


From: ELPA Syncer
Subject: [elpa] externals/corfu 92f4d37: Fix position computation, remove hack (Fix #69)
Date: Fri, 5 Nov 2021 05:57:11 -0400 (EDT)

branch: externals/corfu
commit 92f4d3764ae1b75da2024bed12a906e740ea1b32
Author: Daniel Mendler <mail@daniel-mendler.de>
Commit: Daniel Mendler <mail@daniel-mendler.de>

    Fix position computation, remove hack (Fix #69)
---
 corfu.el | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/corfu.el b/corfu.el
index c731f41..18aa287 100644
--- a/corfu.el
+++ b/corfu.el
@@ -384,14 +384,9 @@ completion began less than that number of seconds ago."
                      (apply #'max corfu-min-width
                             (mapcar #'string-width lines))))
          (row 0)
-         ;;; XXX HACK On Emacs 28 y-coordinate position computation is wrong if
-         ;;; there exists a flymake underline overlay at that point. Therefore
-         ;;; compute the y-coordinate at the line beginning.
-         (x (or (car (posn-x-y (posn-at-point pos))) 0))
-         (y (save-excursion
-              (goto-char pos)
-              (beginning-of-visual-line)
-              (or (cdr (posn-x-y (posn-at-point))) 0))))
+         (pos (posn-x-y (posn-at-point pos)))
+         (x (or (car pos) 0))
+         (y (or (cdr pos) 0)))
     (corfu--make-frame
      (- x mw) y
      (+ (* width cw) mw mw) (* (length lines) ch)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]