[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/consult 7708dc7: consult-completion-in-region: insert i
From: |
ELPA Syncer |
Subject: |
[elpa] externals/consult 7708dc7: consult-completion-in-region: insert initial text for file completion (#463) |
Date: |
Sun, 7 Nov 2021 12:57:13 -0500 (EST) |
branch: externals/consult
commit 7708dc760ac2fc80219b226be27e11bbc9adf5b4
Author: Omar AntolĂn Camarena <omar.antolin@gmail.com>
Commit: GitHub <noreply@github.com>
consult-completion-in-region: insert initial text for file completion (#463)
Previously this was done by using initial as the DIR argument of
read-file-name, but that relied on undocumented behavior of that
function. With this change, we explicitly insert the initial text.
This fixes one of the two issues mentioned in minad/consult#461
---
consult.el | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/consult.el b/consult.el
index b1813f9..a3a8b47 100644
--- a/consult.el
+++ b/consult.el
@@ -2334,13 +2334,15 @@ These configuration options are supported:
'consult--completion-candidate-hook)
(let ((enable-recursive-minibuffers t))
(if (eq category 'file)
- ;; When completing files with
consult-completion-in-region, the point in the
- ;; minibuffer gets placed initially at the
beginning of the last path component.
- ;; By using the filename as DIR argument (second
argument of read-file-name), it
- ;; starts at the end of minibuffer contents, as for
other types of completion.
- ;; However this is undefined behavior since initial
does not only contain the
- ;; directory, but also the filename.
- (read-file-name prompt initial initial
require-match nil predicate)
+ ;; We use read-file-name, since many completion UIs
make it nicer to
+ ;; navigate the file system this way; and we insert
the initial text
+ ;; directly into the minibuffer to allow the user's
completion
+ ;; styles to expand it as appropriate (particularly
useful for the
+ ;; partial-completion and initials styles, which
allow for very
+ ;; condensed path specification).
+ (consult--minibuffer-with-setup-hook
+ (lambda () (insert initial))
+ (read-file-name prompt nil initial require-match
nil predicate))
(completing-read prompt
;; Evaluate completion table in the
original buffer.
;; This is a reasonable thing to do
and required
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [elpa] externals/consult 7708dc7: consult-completion-in-region: insert initial text for file completion (#463),
ELPA Syncer <=