[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/subed 61cf9ce 129/389: Remove garbage tests for point-to-p
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/subed 61cf9ce 129/389: Remove garbage tests for point-to-player syncing |
Date: |
Fri, 3 Dec 2021 11:00:11 -0500 (EST) |
branch: elpa/subed
commit 61cf9ceba777748af99e897643203234e6e27085
Author: Random User <rndusr@posteo.de>
Commit: Random User <rndusr@posteo.de>
Remove garbage tests for point-to-player syncing
It looks like I copy-and-pasted them from the player-to-point tests but
never
rewrote them.
Ideally, there would tests for point-to-player syncing, but all the
complexity
is in the underlying functions that already have tests.
---
tests/test-subed.el | 24 ------------------------
1 file changed, 24 deletions(-)
diff --git a/tests/test-subed.el b/tests/test-subed.el
index 7496286..c5b8266 100644
--- a/tests/test-subed.el
+++ b/tests/test-subed.el
@@ -238,30 +238,6 @@
(expect 'subed-mpv-jump :to-have-been-called-with 5000))
)
-(describe "Syncing point to player"
- :var (subed-mpv-playback-position)
- (before-each
- (setq subed-mpv-playback-position 0)
- (spy-on 'subed--subtitle-msecs-start :and-return-value 5000)
- (spy-on 'subed--subtitle-msecs-stop :and-return-value 6500)
- (spy-on 'subed-mpv-jump))
- (it "does not seek player if point is on current subtitle."
- (setq subed-mpv-playback-position 5000)
- (subed--sync-player-to-point)
- (expect 'subed-mpv-jump :not :to-have-been-called)
- (setq subed-mpv-playback-position 6500)
- (subed--sync-player-to-point)
- (expect 'subed-mpv-jump :not :to-have-been-called))
- (it "seeks player if point is on future subtitle."
- (setq subed-mpv-playback-position 6501)
- (subed--sync-player-to-point)
- (expect 'subed-mpv-jump :to-have-been-called-with 5000))
- (it "seeks player if point is on past subtitle."
- (setq subed-mpv-playback-position 4999)
- (subed--sync-player-to-point)
- (expect 'subed-mpv-jump :to-have-been-called-with 5000))
- )
-
(describe "Temporarily disabling point-to-player syncing"
(before-each
(spy-on 'subed-disable-sync-point-to-player))
- [nongnu] elpa/subed 03dd3c6 106/389: Make subed-move-subtitle-forward/backward work with region (sort of), (continued)
- [nongnu] elpa/subed 03dd3c6 106/389: Make subed-move-subtitle-forward/backward work with region (sort of), ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 0f385d6 110/389: Keep logging debug messages when debugging is disabled, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 612f12a 111/389: Add "moving marked subtitles forward/backward in time" to features, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 4522e1a 113/389: Change keybindings to better conform with major mode conventions, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed ecbfd7f 119/389: Remove useless (progn ...), ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 1950bb0 121/389: subed--replay-adjusted-subtitle: Show debug message before doing the deed, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed f06d5f8 124/389: Add macro: subed--with-subtitle-replay-disabled, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 3fafab8 125/389: Disable subtitle replay during subtitle movement, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 382e83c 126/389: Add more tests for moving subtitles, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed d1a0b2f 127/389: Remove unnecessary spy-on, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 61cf9ce 129/389: Remove garbage tests for point-to-player syncing,
ELPA Syncer <=
- [nongnu] elpa/subed 3aa9a71 131/389: Pause player by default when editing subtitle text, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed d85f988 136/389: Add keybindings for subed-shift-subtitle-forward/backward, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 5b90306 140/389: Round mpv's playback position to prevent float weirdness (n.99999...), ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 0f3add7 141/389: Temporarily disable point-to-player syncing when adjusting time, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 3081983 144/389: Add commentary section to header, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed c069e23 145/389: subed is named "subed", ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 522017e 146/389: Add packaging information to header, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 3bc609d 147/389: Make run-subtitle-time-adjusted-hook not srt specific, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed f3fe9d8 148/389: Make increase/decrease-start/stop-time not srt specific, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 53bad4a 149/389: Explain what moving does in general in comment, ELPA Syncer, 2021/12/03