[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/subed 3753706 318/389: Fix warning about missing function:
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/subed 3753706 318/389: Fix warning about missing function: subed-mpv--sub-add-after-save |
Date: |
Fri, 3 Dec 2021 11:00:49 -0500 (EST) |
branch: elpa/subed
commit 37537063306a0952c9414723b0c1256b3d501839
Author: Random User <rndusr@posteo.de>
Commit: Random User <rndusr@posteo.de>
Fix warning about missing function: subed-mpv--sub-add-after-save
---
subed/subed-mpv.el | 21 ++++++++++++---------
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/subed/subed-mpv.el b/subed/subed-mpv.el
index 36a28ae..dfa8f1e 100644
--- a/subed/subed-mpv.el
+++ b/subed/subed-mpv.el
@@ -343,19 +343,22 @@ Video files are expected to have any of the extensions
listed in
(subed-debug "Opening video file: %s" filepath)
(subed-mpv--client-connect subed-mpv--retry-delays)
(subed-mpv--client-send `(loadfile ,filepath replace))
+ ;; mpv won't add the subtitles if the file doesn't exist yet, so we add
it
+ ;; via after-save-hook.
(if (file-exists-p (buffer-file-name))
- (subed-mpv--client-send `(sub-add ,(buffer-file-name) select))
- ;; mpv won't add the subtitles if the file doesn't exist yet, so we add
- ;; it via after-save-hook. We don't want to add the subtitles on every
- ;; save, so we remove and undefine ourselves after the first save.
- (defun subed-mpv--sub-add-after-save ()
- (subed-mpv--client-send `(sub-add ,(buffer-file-name) select))
- (remove-hook 'after-save-hook #'subed-mpv--sub-add-after-save :local)
- (fmakunbound 'subed-mpv--sub-add-after-save))
- (add-hook 'after-save-hook #'subed-mpv--sub-add-after-save :append
:local))
+ (subed-mpv-add-subtitles (buffer-file-name))
+ (add-hook 'after-save-hook #'subed-mpv--add-subtitle-after-first-save
:append :local))
(subed-mpv--client-send `(observe_property 1 time-pos))
(subed-mpv-playback-speed subed-playback-speed-while-not-typing))))
+(defun subed-mpv--add-subtitle-after-first-save ()
+ "Tell mpv to load subtitles from `buffer-file-name'.
+This function is supposed to be added to `after-save-hook', and
+it removes itself from it so mpv doesn't add the same file every
+time the buffer is saved."
+ (subed-mpv-add-subtitles (buffer-file-name))
+ (remove-hook 'after-save-hook #'subed-mpv--add-subtitle-after-first-save
:local))
+
(defun subed-mpv-kill ()
"Close connection to mpv process and kill the process."
(subed-mpv--client-disconnect)
- [nongnu] elpa/subed f2f11ca 305/389: subed-mpv-find-video: Gracefully handle new file, (continued)
- [nongnu] elpa/subed f2f11ca 305/389: subed-mpv-find-video: Gracefully handle new file, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed fabc7dc 306/389: Move function around, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed aecaf3d 309/389: Better support for fill-paragraph, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed d34bdec 310/389: Fix mismatched parens in example config, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 66889a1 311/389: Fix test: Renumbering does not modify the kill-ring, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed e1fd29b 312/389: subed-srt--regenerate-ids: Do not modify empty buffer, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed ca015d4 313/389: Fix one compile warning, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 317c411 314/389: Remove declarations, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 72020af 315/389: Use long options, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed be43268 316/389: Fix test-compile target, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 3753706 318/389: Fix warning about missing function: subed-mpv--sub-add-after-save,
ELPA Syncer <=
- [nongnu] elpa/subed 473fbc2 319/389: subed-srt--subtitle-text: Improve docstring, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 05ba952 320/389: Only add subtitles file if subed-subtitle-id returns non-nil, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed ea11119 321/389: Inform compiler about unused variables to prevent warnings, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed e8a68c2 322/389: subed-srt--msecs-to-timestamp: Explain save-match-data, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 5c39418 323/389: Copy subed-srt--msecs-to-timestamp to subed-common.el, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed ecfec2b 325/389: Move debugging functions to subed-debug.el, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed f69f769 327/389: Set subed-mode-map in subed.el, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed d110f79 329/389: Stop disabling point-to-player sync on file-loaded event, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed dd4dc8c 332/389: Automatically disable point-to-player sync while looping, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 5957cbe 333/389: Set default subed-loop-seconds-after/before to 1, ELPA Syncer, 2021/12/03