[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/webpaste e11ce74 086/298: Refactor provider priority to ow
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/webpaste e11ce74 086/298: Refactor provider priority to own function |
Date: |
Thu, 9 Dec 2021 18:59:50 -0500 (EST) |
branch: elpa/webpaste
commit e11ce74a8c8e6c41966a8dd797b9fdf66107e4f4
Author: Elis Axelsson <elis.axelsson@gmail.com>
Commit: Elis Axelsson <elis.axelsson@gmail.com>
Refactor provider priority to own function
---
test/webpaste-test.el | 12 ++++++++++++
webpaste.el | 26 +++++++++++++++-----------
2 files changed, 27 insertions(+), 11 deletions(-)
diff --git a/test/webpaste-test.el b/test/webpaste-test.el
index 986589c..7bd414b 100644
--- a/test/webpaste-test.el
+++ b/test/webpaste-test.el
@@ -4,6 +4,18 @@
(require 'ert)
(require 'webpaste)
+(ert-deftest webpaste-autopupulate-provider-priority ()
+ "Test autopopulate of webpaste-provider-priority."
+
+ (setq-default webpaste-provider-priority nil)
+ (setq-default webpaste-providers-alist
+ (list (list "provider1" "lamba")
+ (list "provider2" "lamba")
+ (list "provider3" "lamba")))
+
+ (should (equal (webpaste--get-provider-priority)
+ '("provider1" "provider2" "provider3"))))
+
(ert-deftest callback-from-working-provider ()
"This test just sends a message to a good provider that just works."
diff --git a/webpaste.el b/webpaste.el
index 96ce305..9275913 100644
--- a/webpaste.el
+++ b/webpaste.el
@@ -156,6 +156,20 @@ return it to the user."
:type '(alist :key-type (string :tag "provider name")
:value-type (sexp :tag "webpaste-provider macro definition
for the provider")))
+(defun webpaste--get-provider-priority ()
+ "Return provider priority."
+
+ ;; Populate webpaste-provider-priority if needed
+ (if (eq webpaste-provider-priority nil)
+ (let ((provider-names))
+ ;; Loop provider list
+ (dolist (provider webpaste-providers-alist)
+ (cl-pushnew (car provider) provider-names))
+
+ ;; Set names list
+ (setq-default webpaste-provider-priority (reverse provider-names))))
+
+ webpaste-provider-priority)
;;;###autoload
(defun webpaste-return-url (returned-url)
@@ -188,19 +202,9 @@ might call this function again with TEXT as param to retry
if it failed.
When we run out of providers to try, it will restart since
‘webpaste-tested-providers’ will be empty and then populated again."
- ;; Populate webpaste-provider-priority if needed
- (if (eq webpaste-provider-priority nil)
- (let ((provider-names))
- ;; Loop provider list
- (dolist (provider webpaste-providers-alist)
- (cl-pushnew (car provider) provider-names))
-
- ;; Set names list
- (setq-default webpaste-provider-priority (reverse provider-names))))
-
;; Populate tested providers for this request if needed
(if (eq webpaste-tested-providers nil)
- (setq webpaste-tested-providers webpaste-provider-priority))
+ (setq webpaste-tested-providers (webpaste--get-provider-priority)))
;; Get name of provider at the top of the list
(let ((provider-name (car webpaste-tested-providers)))
- [nongnu] elpa/webpaste dc11b51 078/298: Added code for helper for unit tests, (continued)
- [nongnu] elpa/webpaste dc11b51 078/298: Added code for helper for unit tests, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 8e9f4e0 094/298: Bump required version for webpaste.el because I can't install older, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 0b7ba72 098/298: Added coveralls for file coverage testing, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 25ea405 103/298: Added ERT test for message when returning URL, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste f221c1a 104/298: Added test for pasting entire buffers and regions, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste acf9676 108/298: Added flag to disable failover for provider, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 4867c58 113/298: Backquotes for compacter list, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 8f37214 116/298: Update docs to match function, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 4dd2e1b 111/298: First test of creation of paste providers, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 0b67c54 117/298: Move code up to be defined before the webpaste-provider function, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste e11ce74 086/298: Refactor provider priority to own function,
ELPA Syncer <=
- [nongnu] elpa/webpaste b2ffe99 091/298: Added emacs --version to output in build, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 993db7e 095/298: Added ptpb.pw as new and default provider, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 8861ed8 102/298: Added license-badge, renamed test-vars, stop providing webpaste-test, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste bdc204d 055/298: Autoload return function to always have it available, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 3e81264 067/298: Forgot call to retry sending on failure when refactoring to macro, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste f206653 074/298: Merge branch 'alphapapa-without-eval', ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 87cee69 081/298: Added test for failover to the second provider and not random, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste dcc26da 084/298: Update melpa image links, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 6655ecc 085/298: Rename make compile to make build because it's easier to remember, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 346b5bc 087/298: Rename tests to be prefixed, ELPA Syncer, 2021/12/09