emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/buttercup 62c416a 164/340: Rewrite the pattern loop of but


From: ELPA Syncer
Subject: [nongnu] elpa/buttercup 62c416a 164/340: Rewrite the pattern loop of buttercup-run-discover
Date: Thu, 16 Dec 2021 14:59:26 -0500 (EST)

branch: elpa/buttercup
commit 62c416a534a1b0c2acf1cababc49c435d4e33ea7
Author: Ola Nilsson <ola.nilsson@gmail.com>
Commit: Jorgen Schäfer <Jorgen.Schaefer@gmail.com>

    Rewrite the pattern loop of buttercup-run-discover
    
    Use the buttercup--specs function to replace much of the outer loop.
---
 buttercup.el | 22 +++++++---------------
 1 file changed, 7 insertions(+), 15 deletions(-)

diff --git a/buttercup.el b/buttercup.el
index d72b245..4171ebb 100644
--- a/buttercup.el
+++ b/buttercup.el
@@ -1244,21 +1244,13 @@ current directory."
         (when (not (string-match "\\(^\\|/\\)\\." (file-relative-name file)))
           (load file nil t))))
     (when patterns
-      (let ((suites-or-specs buttercup-suites))
-        (while suites-or-specs
-          (cond
-           ((buttercup-suite-p (car suites-or-specs))
-            (setq suites-or-specs (append suites-or-specs
-                                          (buttercup-suite-children
-                                           (car suites-or-specs)))))
-           ((buttercup-spec-p (car suites-or-specs))
-            (catch 'return
-              (dolist (p patterns)
-                (when (string-match p (buttercup-spec-full-name (car 
suites-or-specs)))
-                  (throw 'return t)))
-              (setf (buttercup-spec-function (car suites-or-specs))
-                    (lambda () (signal 'buttercup-pending "SKIPPED"))))))
-          (setq suites-or-specs (cdr suites-or-specs)))))
+      (dolist (spec (buttercup--specs buttercup-suites))
+        (let ((spec-full-name (buttercup-spec-full-name spec)))
+          (unless (cl-dolist (p patterns)
+                    (when (string-match p spec-full-name)
+                      (cl-return t)))
+            (setf (buttercup-spec-function spec)
+                  (lambda () (signal 'buttercup-pending "SKIPPED")))))))
     (buttercup-run)))
 
 ;;;###autoload



reply via email to

[Prev in Thread] Current Thread [Next in Thread]