[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/buttercup dcc2638 249/340: Revert "Add an option to immedi
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/buttercup dcc2638 249/340: Revert "Add an option to immediately abort Buttercup run if a test fails" |
Date: |
Thu, 16 Dec 2021 14:59:44 -0500 (EST) |
branch: elpa/buttercup
commit dcc26383e23764ed47620f8d73ebc750162ff02d
Author: Ola Nilsson <ola.nilsson@gmail.com>
Commit: Ola Nilsson <ola.nilsson@gmail.com>
Revert "Add an option to immediately abort Buttercup run if a test fails"
Merged prematurely.
This reverts commit e7e5d22572f37f55997122928fc62b073ab57c49.
---
bin/buttercup | 4 +---
buttercup.el | 10 +---------
tests/test-buttercup.el | 1 -
3 files changed, 2 insertions(+), 13 deletions(-)
diff --git a/bin/buttercup b/bin/buttercup
index 962cf07..606436b 100755
--- a/bin/buttercup
+++ b/bin/buttercup
@@ -31,8 +31,6 @@ Buttercup options:
which case tests will be run if they match
any of the given patterns.
---abort-on-failure, -a Abort test execution if any test fails.
-
--no-color, -c Do not colorize test output.
--traceback STYLE When printing backtraces for errors that occur
@@ -72,7 +70,7 @@ do
shift
shift
;;
- "-c"|"--no-color"|"-a"|"--abort-on-failure")
+ "-c"|"--no-color")
BUTTERCUP_ARGS+=("$1")
shift
;;
diff --git a/buttercup.el b/buttercup.el
index 69020ca..2e7afa8 100644
--- a/buttercup.el
+++ b/buttercup.el
@@ -671,9 +671,6 @@ See also `buttercup-define-matcher'."
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;;; Suite and spec data structures
-(defvar buttercup-stop-on-first-failure nil
- "Abort Buttercup testing if any spec fails.")
-
(cl-defstruct buttercup-suite-or-spec
;; The name of this specific suite
description
@@ -1364,9 +1361,6 @@ current directory."
((member (car args) '("-c" "--no-color"))
(setq buttercup-color nil)
(setq args (cdr args)))
- ((member (car args) '("-a" "--abort-on-failure"))
- (setq buttercup-stop-on-first-failure t)
- (setq args (cdr args)))
(t
(push (car args) dirs)
(setq args (cdr args)))))
@@ -1529,9 +1523,7 @@ failed and pending specs."
'(passed pending))
(setf (buttercup-suite-or-spec-status suite-or-spec) status
(buttercup-suite-or-spec-failure-description suite-or-spec)
description
- (buttercup-suite-or-spec-failure-stack suite-or-spec) stack)
- (when (and buttercup-stop-on-first-failure (eq status 'failed))
- (signal 'buttercup-abort "Aborting early because of the failure")))))
+ (buttercup-suite-or-spec-failure-stack suite-or-spec) stack))))
;;;;;;;;;;;;;
;;; Reporters
diff --git a/tests/test-buttercup.el b/tests/test-buttercup.el
index db61f21..a73f2ee 100644
--- a/tests/test-buttercup.el
+++ b/tests/test-buttercup.el
@@ -332,7 +332,6 @@
(buttercup--cleanup-functions :invalid)
buttercup--current-suite
(buttercup-reporter #'ignore)
- buttercup-stop-on-first-failure
buttercup-suites
(buttercup-warning-buffer-name " *ignored buttercup warnings*"))
,@body))
- [nongnu] elpa/buttercup e62ce43 207/340: test: Do not leak functions from "The Spy " test suite, (continued)
- [nongnu] elpa/buttercup e62ce43 207/340: test: Do not leak functions from "The Spy " test suite, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 8b3cfad 214/340: Update test for new warning capture suppression behavior, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 1567c03 215/340: Add emacs-26.3 to CI config, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 6cf8041 229/340: Update writing-tests.md to describe new spy context structs, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup c720cef 233/340: Merge pull request #146 from DarwinAwardWinner/spy-record-errors, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup b2edd35 235/340: Change: (buttercup-define-matcher-for-binary-function) Add newlines, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 818c150 239/340: docs: Clarify the difference between :var and `let', ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup d8ab09d 244/340: Update documentation for the --pattern option in running-tests.md, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup adba24e 246/340: Bump version: 1.19 → 1.20, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup e7e5d22 248/340: Add an option to immediately abort Buttercup run if a test fails, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup dcc2638 249/340: Revert "Add an option to immediately abort Buttercup run if a test fails",
ELPA Syncer <=
- [nongnu] elpa/buttercup 9b30c75 252/340: Make buttercup-x?it and buttercup-suite-add-child return spec, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 3734152 251/340: Make buttercup-describe return the created suite object, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 8271c27 254/340: Only update spec state if it is worse or equal, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 966798f 255/340: Correct all docstrings to pass checkdoc, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup b520dcf 257/340: Print test run duration in an apropriate unit, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 1fd0d8b 260/340: Set state pending for skipped specs for correct initial count, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup b298517 262/340: test: Mark some local function arguments as unused, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 8e29f4c 259/340: Extract buttercup--mark-skipped from buttercup-run-discover, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 669ca99 267/340: test: Split make rule test into test-buttercup and test-docs, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 6655f77 269/340: Update test run duration output in buttercup-reporter-batch, ELPA Syncer, 2021/12/16