emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/popon decdfb02bc 1/2: Fix bug in overlay creating code


From: ELPA Syncer
Subject: [nongnu] elpa/popon decdfb02bc 1/2: Fix bug in overlay creating code
Date: Sun, 5 Jun 2022 06:58:51 -0400 (EDT)

branch: elpa/popon
commit decdfb02bc174a697e0bf33d7ac746ca2fb7d8bf
Author: Akib Azmain Turja <akib@disroot.org>
Commit: Akib Azmain Turja <akib@disroot.org>

    Fix bug in overlay creating code
---
 popon.el | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/popon.el b/popon.el
index b07748cbc1..72c34ee058 100644
--- a/popon.el
+++ b/popon.el
@@ -319,8 +319,8 @@ when LINE-BEGINNINGS was calculated.")
       (while lines-left
         (let ((line (pop lines-left)))
           (when (nth 1 line)
-            (when (and (< (nth 4 line) (point-max))
-                       (/= (char-before (nth 4 line)) ?\n))
+            (when (and (< (point-min) (nth 4 line) (point-max))
+                       (not (eq (char-before (nth 4 line)) ?\n)))
               (let ((ov (make-overlay (nth 4 line) (nth 4 line))))
                 (push ov (window-parameter nil 'popon-overlays))
                 (overlay-put ov 'window (selected-window))
@@ -445,14 +445,15 @@ When FORCE is non-nil, update all overlays."
             (while (window-parameter window 'popon-overlays)
               (delete-overlay
                (pop (window-parameter window 'popon-overlays))))
-            (setq popons (sort popons (lambda (a b)
-                                        (< (popon-priority a)
-                                           (popon-priority b)))))
-            (with-selected-window window
-              (let* ((framebuffer (popon--make-framebuffer)))
-                (dolist (popon popons)
-                  (popon--render popon framebuffer (window-hscroll)))
-                (popon--make-overlays framebuffer)))
+            (when popons
+              (setq popons (sort popons (lambda (a b)
+                                          (< (popon-priority a)
+                                             (popon-priority b)))))
+              (with-selected-window window
+                (let* ((framebuffer (popon--make-framebuffer)))
+                  (dolist (popon popons)
+                    (popon--render popon framebuffer (window-hscroll)))
+                  (popon--make-overlays framebuffer))))
             (set-window-parameter window 'popon-visible-popons popons)
             (set-window-parameter window 'popon-window-start
                                   (window-start window))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]