[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/denote 429763c246 257/355: Fix broken buttons in backli
From: |
ELPA Syncer |
Subject: |
[elpa] externals/denote 429763c246 257/355: Fix broken buttons in backlinks' buffer |
Date: |
Sun, 26 Jun 2022 23:58:30 -0400 (EDT) |
branch: externals/denote
commit 429763c246ac2593a5053a844120d015c977e859
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>
Fix broken buttons in backlinks' buffer
Sorting them after they are inserted breaks them. Thanks to Sven
Seebeck for reporting the regression in issue 16 over at the GitHub
mirror: <https://github.com/protesilaos/denote/issues/16>.
---
denote-link.el | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/denote-link.el b/denote-link.el
index 8176ebd5a6..bdb4263d92 100644
--- a/denote-link.el
+++ b/denote-link.el
@@ -215,17 +215,11 @@ format is always [[denote:IDENTIFIER]]."
buf
`(,@denote-link-backlinks-display-buffer-action)))
-;; NOTE 2022-06-17: This is a `defvar' on purpose, like
-;; `denote-link-add-links'. Read its comment.
-(defvar denote-link-backlinks-sort nil
- "Add REVERSE to `sort-lines' of `denote-link-backlinks' when t.")
-
(defun denote-link--prepare-backlinks (id files &optional title)
"Create backlinks' buffer for ID including FILES.
Use optional TITLE for a prettier heading."
(let ((inhibit-read-only t)
- (buf (format "*denote-backlinks to %s*" id))
- start)
+ (buf (format "*denote-backlinks to %s*" id)))
(with-current-buffer (get-buffer-create buf)
(erase-buffer)
(special-mode)
@@ -234,13 +228,11 @@ Use optional TITLE for a prettier heading."
(heading (format "Backlinks to %S (%s)" title id))
(l (length heading)))
(insert (format "%s\n%s\n\n" heading (make-string l ?-))))
- (setq start (point))
(mapc (lambda (f)
(insert (file-name-nondirectory f))
(make-button (point-at-bol) (point-at-eol) :type
'denote-link-find-file)
(newline))
files)
- (sort-lines denote-link-backlinks-sort start (point))
(goto-char (point-min))
;; NOTE 2022-06-15: Technically this is not Dired. Maybe we
;; should abstract the fontification into a general purpose
- [elpa] externals/denote 979bf352d6 208/355: Clarify requirements for good front matter value, (continued)
- [elpa] externals/denote 979bf352d6 208/355: Clarify requirements for good front matter value, ELPA Syncer, 2022/06/27
- [elpa] externals/denote 0db5be04be 213/355: Use new helper FN for title value in links, ELPA Syncer, 2022/06/27
- [elpa] externals/denote 31fc567702 209/355: Accept optional filetype in front matter formatter, ELPA Syncer, 2022/06/27
- [elpa] externals/denote b64cc491bc 199/355: Add history to denote-link-add-links command, ELPA Syncer, 2022/06/27
- [elpa] externals/denote 4041e437b2 214/355: Add PROTOTYPE of front matter rewrite post-rename, ELPA Syncer, 2022/06/27
- [elpa] externals/denote f4e7cc9ab4 222/355: Document denote-dired-post-rename-functions, ELPA Syncer, 2022/06/27
- [elpa] externals/denote edbd2f7f1b 270/355: Use our pred instead of generic in file filtering, ELPA Syncer, 2022/06/27
- [elpa] externals/denote 10b30d1e15 232/355: Expand manual on journaling with past date, ELPA Syncer, 2022/06/27
- [elpa] externals/denote b5c7bab15c 227/355: Update manual's Acknowledgements, ELPA Syncer, 2022/06/27
- [elpa] externals/denote 8dcb3aea4e 234/355: Add minor tweaks to the manual, ELPA Syncer, 2022/06/27
- [elpa] externals/denote 429763c246 257/355: Fix broken buttons in backlinks' buffer,
ELPA Syncer <=
- [elpa] externals/denote 78f6c7ce35 279/355: Add missing doclicense.texi, ELPA Syncer, 2022/06/27
- [elpa] externals/denote b0d8ad46cf 273/355: Update denote-known-keywords doc string, ELPA Syncer, 2022/06/27
- [elpa] externals/denote da32e7f7f9 249/355: Tweak denote-dired-rewrite-front-matter docstring, ELPA Syncer, 2022/06/27
- [elpa] externals/denote 855c677724 277/355: Reword a minor statement, ELPA Syncer, 2022/06/27
- [elpa] externals/denote 9d599a518e 297/355: Include 'id:' link type in task list, ELPA Syncer, 2022/06/27
- [elpa] externals/denote 7074b25869 289/355: Buttonize all links when inserted in bulk, ELPA Syncer, 2022/06/27
- [elpa] externals/denote 95b5143fc2 274/355: Fix link to zetteldeft alternative package, ELPA Syncer, 2022/06/27
- [elpa] externals/denote 091990d030 325/355: Use 'declare-function' instead of 'autoload', ELPA Syncer, 2022/06/27
- [elpa] externals/denote 26d282be00 309/355: Acknowledge Damien Cassou for code contributions, ELPA Syncer, 2022/06/27
- [elpa] externals/denote bb0211aa66 280/355: Fix indentantion in one point, ELPA Syncer, 2022/06/27