emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/denote c3feb9a0ec 250/355: Remove superfluous when


From: ELPA Syncer
Subject: [elpa] externals/denote c3feb9a0ec 250/355: Remove superfluous when
Date: Sun, 26 Jun 2022 23:58:29 -0400 (EDT)

branch: externals/denote
commit c3feb9a0ec1f61e975877b6e4477a34e67987461
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>

    Remove superfluous when
    
    The diff is mostly indentation.  The very first 'when' was just moved
    inside the subsequent 'when-let*'
---
 denote-dired.el | 56 ++++++++++++++++++++++++++++----------------------------
 1 file changed, 28 insertions(+), 28 deletions(-)

diff --git a/denote-dired.el b/denote-dired.el
index 099faabca5..0436eb46e2 100644
--- a/denote-dired.el
+++ b/denote-dired.el
@@ -313,35 +313,35 @@ replace what isn't there."
 The FILE, TITLE, and KEYWORDS are passed from the renaming
 command and are used to construct a new front matter block if
 appropriate."
-  (when (denote-dired--edit-front-matter-p file)
-    (when-let* ((id (denote-retrieve--filename-identifier file))
-                (date (denote-retrieve--value-date file))
-                (filetype (denote-dired--filetype-heuristics file))
-                (new-front-matter (denote--file-meta-header title date 
keywords id filetype)))
-      (let (old-front-matter front-matter-delimiter)
-        (with-current-buffer (find-file-noselect file)
-          (save-excursion
-            (save-restriction
-              (widen)
-              (goto-char (point-min))
-              (setq front-matter-delimiter 
(denote-dired--front-matter-search-delimiter filetype))
-              (when front-matter-delimiter
-                (setq old-front-matter
-                      (buffer-substring-no-properties
-                       (point-min)
-                       (progn front-matter-delimiter (point)))))))
-          (when (and old-front-matter
-                     (y-or-n-p
-                      (format "%s\n%s\nReplace front matter?"
-                              (propertize old-front-matter 'face 'error)
-                              (propertize new-front-matter 'face 'success))))
-            (delete-region (point-min) front-matter-delimiter)
+  (when-let* ((denote-dired--edit-front-matter-p file)
+              (id (denote-retrieve--filename-identifier file))
+              (date (denote-retrieve--value-date file))
+              (filetype (denote-dired--filetype-heuristics file))
+              (new-front-matter (denote--file-meta-header title date keywords 
id filetype)))
+    (let (old-front-matter front-matter-delimiter)
+      (with-current-buffer (find-file-noselect file)
+        (save-excursion
+          (save-restriction
+            (widen)
             (goto-char (point-min))
-            (insert new-front-matter)
-            ;; FIXME 2022-06-16: Instead of `delete-blank-lines', we
-            ;; should check if we added any new lines and delete only
-            ;; those.
-            (delete-blank-lines)))))))
+            (setq front-matter-delimiter 
(denote-dired--front-matter-search-delimiter filetype))
+            (when front-matter-delimiter
+              (setq old-front-matter
+                    (buffer-substring-no-properties
+                     (point-min)
+                     (progn front-matter-delimiter (point)))))))
+        (when (and old-front-matter
+                   (y-or-n-p
+                    (format "%s\n%s\nReplace front matter?"
+                            (propertize old-front-matter 'face 'error)
+                            (propertize new-front-matter 'face 'success))))
+          (delete-region (point-min) front-matter-delimiter)
+          (goto-char (point-min))
+          (insert new-front-matter)
+          ;; FIXME 2022-06-16: Instead of `delete-blank-lines', we
+          ;; should check if we added any new lines and delete only
+          ;; those.
+          (delete-blank-lines))))))
 
 ;;;; Extra fontification
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]