[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/denote 561553db8e 132/355: fix: Use the correct match s
From: |
ELPA Syncer |
Subject: |
[elpa] externals/denote 561553db8e 132/355: fix: Use the correct match subgroup in `denote-link--find-value` |
Date: |
Sun, 26 Jun 2022 23:58:13 -0400 (EDT) |
branch: externals/denote
commit 561553db8e6615e4489dda1c06951fd78c5caad9
Author: Kaushal Modi <kaushal.modi@gmail.com>
Commit: Kaushal Modi <kaushal.modi@gmail.com>
fix: Use the correct match subgroup in `denote-link--find-value`
Also document that dependence on subgroup in doc strings.
---
denote-link.el | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/denote-link.el b/denote-link.el
index ca0668b980..399c12bd53 100644
--- a/denote-link.el
+++ b/denote-link.el
@@ -95,13 +95,19 @@ files."
"Return value from REGEXP by searching the file."
(goto-char (point-min))
(re-search-forward regexp)
- (match-string-no-properties 3))
+ (match-string-no-properties 1))
-(defconst denote-link--title-regexp "^\\(#\\+\\)?\\(title:\\)[\s\t]+\\(.*\\)"
- "Regular expression for title key and value.")
+(defconst denote-link--title-regexp
"^\\(?:#\\+\\)?\\(?:title:\\)[\s\t]+\\(?1:.*\\)"
+ "Regular expression for title key and value.
-(defconst denote-link--identifier-regexp
"^.?.?\\b\\(identifier\\|ID\\)\\s-*[:=]\\s-*\"?\\([0-9T]+\\)"
- "Regular expression for filename key and value.")
+The match that needs to be extracted is explicityly marked as
+group 1. `denote-link--find-value' uses the group 1 sting.")
+
+(defconst denote-link--identifier-regexp
"^.?.?\\b\\(?:identifier\\|ID\\)\\s-*[:=]\\s-*\"?\\(?1:[0-9T]+\\)"
+ "Regular expression for filename key and value.
+
+The match that needs to be extracted is explicityly marked as
+group 1. `denote-link--find-value' uses the group 1 sting.")
(defconst denote-link--link-format-org "[[file:%s][%s (%s)]]"
"Format of Org link to note.")
- [elpa] externals/denote 20a915672e 056/355: Remove interactive-only from 'denote', (continued)
- [elpa] externals/denote 20a915672e 056/355: Remove interactive-only from 'denote', ELPA Syncer, 2022/06/27
- [elpa] externals/denote 0519be74a9 121/355: Add PROOF-OF-CONCEPT denote-link-backlinks, ELPA Syncer, 2022/06/27
- [elpa] externals/denote a107fbf5d7 120/355: Make minor tweaks in the manual, ELPA Syncer, 2022/06/27
- [elpa] externals/denote 254a6cd0f3 112/355: Update date function; enforce RFC3339 when needed, ELPA Syncer, 2022/06/27
- [elpa] externals/denote f1f9f757ef 109/355: Include markdown-toml sample in the manual, ELPA Syncer, 2022/06/27
- [elpa] externals/denote 24371b4c86 129/355: fix: Update the identifier regexp to recognize TOML identifier too, ELPA Syncer, 2022/06/27
- [elpa] externals/denote 0cb5c9f06e 122/355: Simplify attribution comment to ox-hugo, ELPA Syncer, 2022/06/27
- [elpa] externals/denote 79fbe2493b 135/355: Merge pull request #11 from kaushalmodi/update-identifier-regexp, ELPA Syncer, 2022/06/27
- [elpa] externals/denote 808a2c29f9 140/355: Acknowledge Peter Povinec for file-naming refinements, ELPA Syncer, 2022/06/27
- [elpa] externals/denote 083b3bfc89 144/355: Use better example for file renaming, ELPA Syncer, 2022/06/27
- [elpa] externals/denote 561553db8e 132/355: fix: Use the correct match subgroup in `denote-link--find-value`,
ELPA Syncer <=
- [elpa] externals/denote e1c18f5f57 136/355: Remove potentially bad advice from the manual, ELPA Syncer, 2022/06/27
- [elpa] externals/denote 7b719e6274 152/355: Add user option to disable multi-word keywords, ELPA Syncer, 2022/06/27
- [elpa] externals/denote 25fa79e8d9 146/355: Refine denote-retrieve internals, ELPA Syncer, 2022/06/27
- [elpa] externals/denote 0165b00ddb 145/355: Use only denote-retrieve functions in denote-link, ELPA Syncer, 2022/06/27
- [elpa] externals/denote f57e9c5c9f 165/355: Change internal variable symbols for consistency, ELPA Syncer, 2022/06/27
- [elpa] externals/denote 8565d36e7d 161/355: Add note in the manual about journal/diary, ELPA Syncer, 2022/06/27
- [elpa] externals/denote be58aec5db 163/355: Include journal sample that prompts for TITLE, ELPA Syncer, 2022/06/27
- [elpa] externals/denote d66312e517 172/355: Fix regression in file extension caused by f57e9c5, ELPA Syncer, 2022/06/27
- [elpa] externals/denote 553c10a9cc 178/355: Tweak doc string, ELPA Syncer, 2022/06/27
- [elpa] externals/denote 8e6e2736dc 174/355: Add generic denote-link-find-file, ELPA Syncer, 2022/06/27