emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/org 88c85d620b: org-map-entries: Do not demand file buf


From: ELPA Syncer
Subject: [elpa] externals/org 88c85d620b: org-map-entries: Do not demand file buffer when SCOPE is nil
Date: Tue, 11 Oct 2022 04:57:57 -0400 (EDT)

branch: externals/org
commit 88c85d620bb0153f0290552b5eb3b333a32f7fb8
Author: Ihor Radchenko <yantar92@gmail.com>
Commit: Ihor Radchenko <yantar92@gmail.com>

    org-map-entries: Do not demand file buffer when SCOPE is nil
    
    * lisp/org.el (org-map-entries): Avoid calling
    `org-agenda-prepare-buffers' for non-file buffers.
    `org-agenda-prepare-buffers' expects a file buffer and gives
    unexpected dialogue otherwise.  Since `org-agenda-prepare-buffer' only
    contains optional cache calculations and things only useful for agenda
    generation, not calling it should be reasonably safe.
    
    Reported-by: Rodrigo Morales <moralesrodrigo1100@gmail.com>
    Link: https://orgmode.org/list/871r54m6xm.fsf@gmail.com
---
 lisp/org.el | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 17e8b663fa..36993e165f 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -12187,8 +12187,11 @@ a *different* entry, you cannot use these techniques."
 
          (if (not scope)
              (progn
-               (org-agenda-prepare-buffers
-                (and buffer-file-name (list buffer-file-name)))
+                ;; Agenda expects a file buffer.  Skip over refreshing
+                ;; agenda cache for non-file buffers.
+                (when buffer-file-name
+                 (org-agenda-prepare-buffers
+                  (and buffer-file-name (list buffer-file-name))))
                (setq res
                      (org-scan-tags
                       func matcher org--matcher-tags-todo-only start-level)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]