emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/sly 8872d38062 4/5: Per #485: Remove nonfunctional hypersp


From: ELPA Syncer
Subject: [nongnu] elpa/sly 8872d38062 4/5: Per #485: Remove nonfunctional hyperspec lookup from ABCL backend
Date: Tue, 18 Oct 2022 06:59:16 -0400 (EDT)

branch: elpa/sly
commit 8872d3806220deee869c6481654b36d86c1afc68
Author: Gordon Brown <gbrown@spu.edu>
Commit: João Távora <joaotavora@gmail.com>

    Per #485: Remove nonfunctional hyperspec lookup from ABCL backend
    
    This shouldn't be backend-specific anyway.
    
    * slynk/backend/abcl.lisp: Rework.
---
 slynk/backend/abcl.lisp | 24 +-----------------------
 1 file changed, 1 insertion(+), 23 deletions(-)

diff --git a/slynk/backend/abcl.lisp b/slynk/backend/abcl.lisp
index c36403edf8..709a51c65b 100644
--- a/slynk/backend/abcl.lisp
+++ b/slynk/backend/abcl.lisp
@@ -1044,21 +1044,6 @@
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 ;;;; Inspecting
 
-;;; BEGIN FIXME move into generalized Slynk infrastructure, or add to contrib 
mechanism
-;; this is only for hyperspec request in an inspector window
-;; TODO have sly-hyperspec-lookup respect this variable too
-(defvar *sly-inspector-hyperspec-in-browser* t
-  "If t then invoking hyperspec within the inspector browses the hyperspec in 
an emacs buffer, otherwise respecting the value of browse-url-browser-function")
-
-(defun hyperspec-do (name)
-  (let ((form `(let ((browse-url-browser-function 
-                       ,(if *sly-inspector-hyperspec-in-browser* 
-                            '(lambda(a v) (eww a))
-                            'browse-url-browser-function)))
-                        (sly-hyperdoc-lookup ,name))))
-    (slynk:eval-in-emacs form t)))
-;;; END FIXME move into generalized Slynk infrastructure, or add to contrib 
mechanism
-
 ;;; Although by convention toString() is supposed to be a
 ;;; non-computationally expensive operation this isn't always the
 ;;; case, so make its computation a user interaction.
@@ -1189,14 +1174,7 @@
                                 `(:label ,(jcall "getName" field))
                                 ": "
                                 `(:value ,value ,(princ-to-string value))
-                                '(:newline)))))))
-      #+abcl-introspect
-      ,@(when (and (function-name f) (symbolp (function-name f))
-                   (eq (symbol-package (function-name f)) (find-package :cl)))
-          (list '(:newline) (list :action "Lookup in hyperspec"
-                                  (lambda () (hyperspec-do (symbol-name 
(function-name f))))
-                                  :refreshp nil)
-                '(:newline)))))
+                               '(:newline)))))))))
 
 (defmethod emacs-inspect ((o java:java-object))
   (if (jinstance-of-p o (jclass "java.lang.Class"))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]