emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/agitate 53a3860ee5 2/7: Remove some needless comments


From: ELPA Syncer
Subject: [elpa] externals/agitate 53a3860ee5 2/7: Remove some needless comments
Date: Tue, 18 Oct 2022 20:57:17 -0400 (EDT)

branch: externals/agitate
commit 53a3860ee549bb478f3609fcaaf5702690c1af92
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>

    Remove some needless comments
    
    We can review those if the need arises organically.  They do not have
    to be kept around.
---
 agitate.el | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/agitate.el b/agitate.el
index bfada924df..7eb9836780 100644
--- a/agitate.el
+++ b/agitate.el
@@ -247,12 +247,6 @@ Prompt for entry among those declared in
 (defvar agitate--previous-window-configuration nil
   "Store the last window configuration.")
 
-;; FIXME 2022-10-01: What happens if the user changes the window
-;; layout after they entre this view but before finalising the
-;; log-edit?  That would restore the last window configuration, but is
-;; that the right thing?  Should we dedicate buffers to their windows
-;; and make it unbreakable?  Use atomic windows?  Feels too much...  I
-;; think keeping it simple is better.
 ;;;###autoload
 (define-minor-mode agitate-log-edit-informative-mode
   "PROTOTYPE Apply a specific window configuation when entering log-view mode.
@@ -382,11 +376,6 @@ option `agitate-log-limit'."
          (default-directory (vc-root-dir)))
     (completing-read
      prompt
-     ;; TODO 2022-09-29: Define a completion category that can work
-     ;; with `consult', `embark', `marginalia', and friends?
-     ;;
-     ;; TODO 2022-09-29: Define an annotation function?  Though we can
-     ;; just tweak the git arguments.
      (agitate--completion-table-no-sort
       (process-lines
        vc-git-program "log"
@@ -426,8 +415,6 @@ option `agitate-log-limit'."
                        f)))
            (buf "*agitate-vc-git-show*"))
       (vc-git--call (get-buffer-create buf) "show" "--patch-with-stat" 
revision)
-      ;; TODO 2022-09-27: What else do we need to set up in such a
-      ;; buffer?
       (with-current-buffer (pop-to-buffer buf)
         (diff-mode)
         (setq-local revert-buffer-function
@@ -457,8 +444,6 @@ completion."
   (interactive (list (agitate--vc-git-tag-prompt)))
   (let* ((buf "*agitate-vc-git-show*"))
     (vc-git--call (get-buffer-create buf) "show" tag)
-    ;; TODO 2022-09-27: What else do we need to set up in such a
-    ;; buffer?
     (with-current-buffer (pop-to-buffer buf)
       (diff-mode)
       (setq-local revert-buffer-function



reply via email to

[Prev in Thread] Current Thread [Next in Thread]